-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: model provider configuration validation #1019
Open
iwilltry42
wants to merge
2
commits into
obot-platform:main
Choose a base branch
from
iwilltry42:feat/model-provider-validation
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
feat: model provider configuration validation #1019
iwilltry42
wants to merge
2
commits into
obot-platform:main
from
iwilltry42:feat/model-provider-validation
+186
−11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iwilltry42
force-pushed
the
feat/model-provider-validation
branch
from
December 23, 2024 10:28
6c75635
to
b479edc
Compare
iwilltry42
force-pushed
the
feat/model-provider-validation
branch
from
January 3, 2025 12:45
194ab84
to
13ca8d7
Compare
iwilltry42
changed the title
feat: surface model configuration errors
feat: model provider configuration validation
Jan 3, 2025
iwilltry42
force-pushed
the
feat/model-provider-validation
branch
3 times, most recently
from
January 3, 2025 20:47
98a4d52
to
e4bbfe1
Compare
iwilltry42
requested review from
ivyjeong13,
njhale,
sanjay920,
StrongMonkey,
ryanhopperlowe and
g-linville
January 3, 2025 20:53
iwilltry42
force-pushed
the
feat/model-provider-validation
branch
from
January 3, 2025 20:56
e4bbfe1
to
fb1cb19
Compare
ryanhopperlowe
approved these changes
Jan 6, 2025
thedadams
reviewed
Jan 6, 2025
pkg/api/handlers/modelprovider.go
Outdated
}, | ||
} | ||
|
||
if err := req.Get(thread, thread.Name); apierrors.IsNotFound(err) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this work? It looks like thread.Name
will always be empty here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Likely not - leftover from when I didn't use GenerateName
iwilltry42
force-pushed
the
feat/model-provider-validation
branch
from
January 8, 2025 16:56
384c9dc
to
f4f054d
Compare
before saving the provider config
iwilltry42
force-pushed
the
feat/model-provider-validation
branch
from
January 10, 2025 14:52
f4f054d
to
08da9a2
Compare
thedadams
approved these changes
Jan 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Important: This draft PR contains a couple of changes.
/available-models/{model-provider-id}
so it shows the error message to the uservalidate from <model-provider-tool>
to validate the config (if available)Tested with the "reference implementation" which is the gemini-vertex provider: #986 / obot-platform/tools#297
Ref:
configured
state (with no indication of error) after it is being misconfigured. #819