feat: add support for credential auth for non-tool-references #1139
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thedadams
requested review from
njhale,
StrongMonkey,
iwilltry42 and
g-linville
|
Shoot. One more change needs to be made. Going to draft for now. EDIT: fixed and ready for review now. |
thedadams
force-pushed
the
cred-auth-non-ref-support
branch
from
0e66d6b to
c9620ad
Compare
thedadams
requested review from
njhale,
StrongMonkey,
iwilltry42 and
g-linville
Support authentication for agent and workflow tools that use non-tool-references in their definition. That is, a GitHub hosted tool or a local tool. During the implementation and testing for non-tool-references, I also spotted a gap: nested tools. That is, if an agent uses a tool that uses a tool that has a credential, then the authentication for that tool would not be processed. After this change, it will. Signed-off-by: Donnie Adams <[email protected]>
thedadams
force-pushed
the
cred-auth-non-ref-support
branch
from
c9620ad to
2fa2478
Compare
StrongMonkey
approved these changes
Jan 8, 2025
iwilltry42
approved these changes
Jan 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support authentication for agent and workflow tools that use non-tool-references in their definition. That is, a GitHub-hosted tool or a local tool.
During the implementation and testing for non-tool-references, I also spotted a gap: nested tools. That is, if an agent uses a tool that uses a tool that has a credential, then the authentication for that tool would not be processed. After this change, it will.