feat: add vitest & react-testing-library #1522
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
ivyjeong13
commented
Jan 29, 2025
•
ivyjeong13
commented
- install vitest & react-testing-library
- add some base test cases for agent
ivyjeong13
force-pushed
the
feat/add-vitest-react-testing-library
branch
6 times, most recently
from
71570b5 to
0cbe0f1
Compare
ivyjeong13
commented
Jan 30, 2025
| @@ -9,25 +9,25 @@ export const KNOWLEDGE_TOOL = "knowledge"; | |||
| export type AgentBase = { | |||
| name: string; | |||
| description: string; | |||
| temperature?: number; | |||
| cache?: boolean; | |||
| temperature?: number | null; | |||
There was a problem hiding this comment.
While going through and making mocks, noticed some properties that had null that didn't match with your types so updated them as well. Lemme know if that's not needed and can revert!
ivyjeong13
commented
Jan 30, 2025
ivyjeong13
commented
Jan 30, 2025
| server: { | ||
| watch: { | ||
| // Exclude test files from HMR | ||
| ignored: !process.env.VITEST |
There was a problem hiding this comment.
Added changes here to avoid hot reloading React application when changing test files while running make dev. But when running pnpm test, changes in files will still trigger a re-run of the test suites.
ivyjeong13
force-pushed
the
feat/add-vitest-react-testing-library
branch
2 times, most recently
from
7265f6a to
209c862
Compare
ivyjeong13
force-pushed
the
feat/add-vitest-react-testing-library
branch
from
6bd492c to
6b6ead4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.