Fix: Set Obot dark mode icon to blue #1533
Merged
+7
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We use invert logic when an agent doesn't have an explicit dark icon set. Generally, this should be fine, but for obot, we want the dark mode to be blue, not the orange, which is the inversion of blue. Signed-off-by: Craig Jellick <[email protected]>
cjellick
requested review from
thedadams,
ivyjeong13,
njhale,
StrongMonkey and
g-linville
g-linville
approved these changes
Jan 30, 2025
StrongMonkey
approved these changes
Jan 30, 2025
|
This issue is addressed when testing with latest builds. User ui |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We use invert logic when an agent doesn't have an explicit dark icon set. Generally, this should be fine, but for obot, we want the dark mode to be blue, not the orange, which is the inversion of blue.
Not going to open an issue for this. will just throw the PR onto the board.
Expectation is that this fixes new installs and our existing environments, in both the admin and user ui
Here's a screenshot of what I'm fixing:
Signed-off-by: Craig Jellick [email protected]