feat: add tools table for creating and deleting tools #284
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
21
to
30
| await ToolReferenceService.createToolReference({ | ||
| toolReference: { ...data, toolType: "tool" }, | ||
| }); | ||
| reset(); | ||
| onSuccess(); | ||
| } catch (error) { | ||
| console.error("Failed to create tool reference:", error); | ||
| } finally { | ||
| setIsSubmitting(false); | ||
| } | ||
| }; | ||
|
|
There was a problem hiding this comment.
const { execute: onSubmit, isLoading } = useAsync(
async (data: CreateToolReference) => {
await ToolReferenceService.createToolReference({
toolReference: { ...data, toolType: "tool" },
});
reset();
onSuccess();
},
{
onError: (error) =>
console.error("Failed to create tool reference:", error),
}
);There was a problem hiding this comment.
🤦🏻 So much better, thanks Ryan.
Comment on lines
110
to
143
| <Dialog open={isDeleteDialogOpen} onOpenChange={setIsDeleteDialogOpen}> | ||
| <DialogTrigger asChild> | ||
| <Button variant="ghost" size="sm"> | ||
| <Trash2Icon className="h-4 w-4" /> | ||
| </Button> | ||
| </DialogTrigger> | ||
| <DialogContent> | ||
| <DialogHeader> | ||
| <DialogTitle>Are you sure?</DialogTitle> | ||
| <DialogDescription> | ||
| This action cannot be undone. This will permanently | ||
| delete the tool reference. | ||
| </DialogDescription> | ||
| </DialogHeader> | ||
| <DialogFooter> | ||
| <Button | ||
| variant="outline" | ||
| onClick={() => setIsDeleteDialogOpen(false)} | ||
| > | ||
| Cancel | ||
| </Button> | ||
| <Button | ||
| variant="destructive" | ||
| onClick={() => { | ||
| onDelete(); | ||
| setIsDeleteDialogOpen(false); | ||
| }} | ||
| > | ||
| Delete | ||
| </Button> | ||
| </DialogFooter> | ||
| </DialogContent> | ||
| </Dialog> | ||
| ); |
There was a problem hiding this comment.
I created a helper component called ConfirmationDialog that will handle this quite nicely
There was a problem hiding this comment.
Nice, yep does this exactly.
Comment on lines
+21
to
+33
| const { data: tools, mutate } = useSWR( | ||
| ToolReferenceService.getToolReferences.key("tool"), | ||
| () => ToolReferenceService.getToolReferences("tool") | ||
| ); |
There was a problem hiding this comment.
nit: preload in a clientLoader?
tylerslaton
force-pushed
the
tools-view
branch
from
2c60d6f to
06e036d
Compare
|
@ryanhopperlowe Mind giving this another look? |
tylerslaton
force-pushed
the
tools-view
branch
from
06e036d to
f4e4978
Compare
Signed-off-by: tylerslaton <[email protected]>
tylerslaton
force-pushed
the
tools-view
branch
from
f4e4978 to
a9cc9db
Compare
|
All set here! |
ryanhopperlowe
approved these changes
Oct 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Screen.Recording.2024-10-23.at.11.43.25.AM.mov