fix: use different key for tool reference getters #299
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a workaround to make the SWR caching work nicely with the getToolReferences function. The reason we do this is because otherwise the SWR cache will not be invalidated between the two function calls and thus break type safety since types in TypeScript are erased at runtime. as-map=true does not exist in the API. Signed-off-by: tylerslaton <[email protected]>
ryanhopperlowe
approved these changes
Oct 24, 2024
| // the two function calls and thus break type safety since types in | ||
| // TypeScript are erased at runtime. as-map=true does not exist in | ||
| // the API. | ||
| url: ApiRoutes.toolReferences.base({ type }).path + "?as-map=true", |
There was a problem hiding this comment.
instead of modifying the url, can you just add another property (i.e. responseType: 'map' or modifier: 'as-map')
There was a problem hiding this comment.
Did not even think about that haha, good call.
|
1 nit, but other than that LGTM! |
tylerslaton
force-pushed
the
fix-292
branch
2 times, most recently
from
ead6d2f to
309c5cc
Compare
Signed-off-by: tylerslaton <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a workaround to make the SWR caching work nicely with the getToolReferences function. The reason we do this is because otherwise the SWR cache will not be invalidated between the two function calls and thus break type safety since types in TypeScript are erased at runtime. as-map=true does not exist in the API.
In addition, this PR also updates the ToolGrid to use the same getter as the ToolCatalog.
#292