Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ui/feat/slack-oauth-app #307

Merged

Conversation

ryanhopperlowe
Copy link
Contributor

Signed-off-by: Ryan Hopper-Lowe [email protected]

@ryanhopperlowe ryanhopperlowe force-pushed the ui/feat/slack-oauth-app branch 2 times, most recently from 59e28fa to 4a18729 Compare October 25, 2024 19:09
Copy link
Contributor

@tylerslaton tylerslaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, small nitpick - the backticks still render. I'd expect this to be a code component or something but maybe this fine as is. Wanted to make sure we were aware of it though. If we want to fix it we'd have to do some custom styling in ReactMarkdown.

Screenshot 2024-10-25 at 3 54 47 PM

@ryanhopperlowe
Copy link
Contributor Author

ryanhopperlowe commented Oct 25, 2024

Approved, small nitpick - the backticks still render. I'd expect this to be a code component or something but maybe this fine as is. Wanted to make sure we were aware of it though. If we want to fix it we'd have to do some custom styling in ReactMarkdown.

Screenshot 2024-10-25 at 3 54 47 PM

I actually thought it was kind of nice, because it looks like quotes, and it's bolded. I like that it draws the user's attention AND tells them to look for "this exact text"

@ryanhopperlowe ryanhopperlowe merged commit 15f8f1e into obot-platform:main Oct 25, 2024
1 check passed
@ryanhopperlowe ryanhopperlowe deleted the ui/feat/slack-oauth-app branch October 25, 2024 20:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants