Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: fix ui to render error from data source properly #313

Closed
wants to merge 1 commit into from

Conversation

StrongMonkey
Copy link
Contributor

@StrongMonkey StrongMonkey commented Oct 24, 2024

#186

Fixed an issue to render the error properly in ui

Comment on lines +33 to +37
className={`text-sm mr-2 ${
!source.runID && source.error
? "text-destructive"
: "text-gray-500"
}`}
Copy link
Contributor

@ryanhopperlowe ryanhopperlowe Oct 28, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: we have a helper (import { cn } from "~/lib/utils") that will clean up any duplicates in your styles + clean up the code a bit.

Also can you use a preset color from the tailwind.config.ts instead of text-gray-500 (I'm guessing you want something like text-muted or text-secondary-foreground but use whichever color makes most sense to you)

                    className={cn(`text-sm mr-2`, {
                        "text-destructive": !source.runID && source.error,
                        "text-muted": source.runID || !source.error,
                    })}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants