feat: add button to a user's thread in table view #328
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ui/admin/app/routes/_auth.users.tsx
Outdated
| const users = getUsers.data || []; | ||
|
|
||
| // Fetch threads for all users |
There was a problem hiding this comment.
If there is a /users api that can fetch all users, it might make more sense to call 1 api for the users and 1 api for all threads. Is that possible?
There was a problem hiding this comment.
Ah yeah, that's true. I updated it to make a map of threadIds and then use those in the rows. What do you think?
Signed-off-by: tylerslaton <[email protected]>
tylerslaton
force-pushed
the
user-thread-mapping
branch
from
2bf8a10 to
52798c9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Screen.Recording.2024-10-25.at.10.48.50.AM.mov