refactor: overhaul admin ux and ui #377
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This includes a lot of changes to the admin UI as per a big batch of feedback from @ibuildthecloud. The main changes are: - ToolGrid component has been updated to: * Sort alphabetically in each category * Show each tool's individual icon as well as the category icon * Remove hover effects for badges * CreateNewTool button now only has reference field * Fix a bug where the tool grid had an empty tool for bundless categories * Fixed a bug with the tool tip for category headers - Overall background of the application is now bg-background - OAuth app dialog is now much wider - Fix a broken link for threads breadcrumb - Agent edit page is not very different * No more accordions for tools and knowledge * Add tool now opens a new Dialog instead of a popover - ToolTable now has a onRowClick and disableClickPropagation prop - Thread and agent tables now link to their respective pages Signed-off-by: tylerslaton <[email protected]>
ryanhopperlowe
approved these changes
Oct 31, 2024
| /> | ||
| </div> | ||
|
|
||
| <div className="p-4 flex-auto space-y-4"> |
There was a problem hiding this comment.
there goes our last stoppage of polling in knowledge :(
| @@ -100,29 +95,24 @@ export function ToolForm({ | |||
| ))} | |||
| </div> | |||
| <div className="flex justify-end w-full my-4"> | |||
| <Popover> | |||
| <PopoverTrigger asChild> | |||
| <Dialog> | |||
There was a problem hiding this comment.
This looks way better 🙌
| > | ||
| <Button | ||
| variant="ghost" | ||
| size="sm" |
Comment on lines
34
to
42
| tool.name | ||
| ?.toLowerCase() | ||
| .includes(searchTerm.toLowerCase()) || | ||
| tool.metadata?.category | ||
| ?.toLowerCase() | ||
| .includes(searchTerm.toLowerCase()) || | ||
| tool.description | ||
| ?.toLowerCase() | ||
| .includes(searchTerm.toLowerCase()) |
There was a problem hiding this comment.
pro-tip
[tool.name, tool.metadata?.category, tool.description]
.filter(x => !!x)
.join("|")
.toLowerCase()
.includes(searchTerm.toLowerCase())is a bit cleaner
Signed-off-by: tylerslaton <[email protected]>
ryanhopperlowe
approved these changes
Oct 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This includes a lot of changes to the admin UI as
per a big batch of feedback from @ibuildthecloud.
The main changes are: