Ui/chore/async-message-loading #440
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is this behavior intentional? Seems a bit weird to drop the optimistic rendering of the user's message. Screen.Recording.2024-11-05.at.11.39.09.AM.mov |
@tylerslaton - yeah - we discussed with darren. he said to drop the optimistic rendinering of the user message and he intends to compensate a bit on the server side (though itll still have to deal with network latency) |
tylerslaton
approved these changes
Nov 5, 2024
Signed-off-by: Ryan Hopper-Lowe <[email protected]>
…mplete Signed-off-by: Ryan Hopper-Lowe <[email protected]>
ryanhopperlowe
force-pushed
the
ui/chore/async-message-loading
branch
from
dbdbf2f to
a0731cc
Compare
This was referenced Nov 6, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the agent chat to load all messages asynchronously through an event stream.
replayCompleteflag)Signed-off-by: Ryan Hopper-Lowe [email protected]