Chore: Knowledge UI revamp #450
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StrongMonkey
force-pushed
the
knowledge-ui-rewrite-1
branch
2 times, most recently
from
53c33af to
ca023c7
Compare
Signed-off-by: Daishan Peng <[email protected]>
StrongMonkey
force-pushed
the
knowledge-ui-rewrite-1
branch
from
ca023c7 to
483c85e
Compare
There was a problem hiding this comment.
did you reset the button component here?
There was a problem hiding this comment.
by adding [&_svg]:size-4, you inadvertently made all buttons with size-icon look really small...
There was a problem hiding this comment.
I like the addition of the classes there, but can you add [&_svg]:size-6 to the size.icon variant?
| @@ -242,7 +235,6 @@ export function CustomOAuthAppForm({ | |||
| </Button> | |||
|
|
|||
| <Button | |||
| loading={isLoading} | |||
There was a problem hiding this comment.
Why did this get removed?
Comment on lines
+19
to
+20
| const [isOpen, setIsOpen] = useState(false); | ||
| const [oauthUrl, setOauthUrl] = useState(""); |
There was a problem hiding this comment.
shouldn't need 2 sets of state here.
const [oauthUrl, setOauthUrl] = useState("");
const isOpen = !!oauthUrl
const onClose = () => setOauthUrl("")
should cover all your bases here
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make Knowledge UI great again.