feat: enhance chat functionality with new ChatHelpers component and optional tool deletion #857
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryanhopperlowe
force-pushed
the
feat/admin/chat-helpers
branch
from
2b3c3f5 to
512896a
Compare
ryanhopperlowe
requested review from
ivyjeong13,
cjellick,
thedadams,
njhale,
StrongMonkey and
g-linville
ryanhopperlowe
force-pushed
the
feat/admin/chat-helpers
branch
5 times, most recently
from
d416f06 to
1cd0ca8
Compare
ivyjeong13
reviewed
Dec 17, 2024
ivyjeong13
approved these changes
Dec 17, 2024
ryanhopperlowe
commented
Dec 17, 2024
pkg/api/handlers/threads.go
Outdated
Comment on lines
233
to
235
| possibleTools := slices.Concat(agent.Spec.Manifest.AvailableThreadTools, agent.Spec.Manifest.DefaultThreadTools) | ||
|
|
||
| if !slices.Contains(possibleTools, newTool) { |
There was a problem hiding this comment.
@ backend guys, I wrote some Go code here
ryanhopperlowe
force-pushed
the
feat/admin/chat-helpers
branch
from
09be930 to
439b8b4
Compare
…ptional tool deletion - Added ChatHelpers component to provide tools and knowledge information in the chat interface. - Updated ToolEntry component to make the onDelete prop optional, allowing for conditional rendering of the delete button. - Adjusted Chat component layout to include padding and integrate ChatHelpers. - Minor style adjustments in Chatbar component to remove unnecessary padding. This update improves the user experience by providing additional context and functionality within the chat interface.
ryanhopperlowe
force-pushed
the
feat/admin/chat-helpers
branch
from
bfebd0e to
94b2b96
Compare
thedadams
approved these changes
Dec 17, 2024
pkg/api/handlers/threads.go
Outdated
Comment on lines
233
to
235
| possibleTools := slices.Concat(agent.Spec.Manifest.AvailableThreadTools, agent.Spec.Manifest.DefaultThreadTools) | ||
|
|
||
| if !slices.Contains(possibleTools, newTool) { |
There was a problem hiding this comment.
This is fine. A small change would save allocating a whole new slice here.
Suggested change
| possibleTools := slices.Concat(agent.Spec.Manifest.AvailableThreadTools, agent.Spec.Manifest.DefaultThreadTools) | |
| if !slices.Contains(possibleTools, newTool) { | |
| possibleTools := slices.Concat(agent.Spec.Manifest.AvailableThreadTools, agent.Spec.Manifest.DefaultThreadTools) | |
| if !slices.Contains(agent.Spec.Manifest.AvailableThreadTools, newTool) && !slices.Contains(agent.Spec.Manifest.DefaultThreadTools, newTool) { |
…ability on thread update
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Textareacomponent to be composable by constructhttps://www.loom.com/share/26ec74e5ac4547d0b40917a02076c8bb?sid=3ab13512-7c34-4ae4-81b3-dc455094c0f8
This update improves the user experience by providing additional context and functionality within the chat interface.