feat: implement new linter rules in preparation for react compiler #961
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
ryanhopperlowe
commented
Dec 18, 2024
ryanhopperlowe
commented
- All code logic should be identical
- did some swapping out of refs for state vars to improve adherence to the rules of react
ivyjeong13
reviewed
Dec 19, 2024
ivyjeong13
reviewed
Dec 19, 2024
| @@ -81,6 +81,7 @@ | |||
| "eslint-plugin-jsx-a11y": "^6.10.0", | |||
| "eslint-plugin-prettier": "^5.2.1", | |||
| "eslint-plugin-react": "^7.36.1", | |||
| "eslint-plugin-react-compiler": "19.0.0-beta-201e55d-20241215", | |||
- All code logic should be identical - did some swapping out of refs for state vars to improve adherence to the rules of react
ryanhopperlowe
force-pushed
the
chore/admin/implement-react-compiler-linter-rules
branch
from
8d9bcba to
d5b9e42
Compare
ryanhopperlowe
deleted the
chore/admin/implement-react-compiler-linter-rules
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.