-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
enhance: add create and write google docs tools #360
enhance: add create and write google docs tools #360
Conversation
google/credential/tool.gpt
Outdated
@@ -7,6 +7,7 @@ Share Credential: ../../oauth2 as google | |||
https://www.googleapis.com/auth/userinfo.profile | |||
https://www.googleapis.com/auth/spreadsheets | |||
https://www.googleapis.com/auth/documents.readonly |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you remove this scope? We don't need write AND readonly
003ff82
to
1994186
Compare
Correct me if I'm wrong, but it looks like once the doc title is created, it can't get updated anymore by the |
google/docs/tool.gpt
Outdated
Metadata: bundle: true | ||
Description: Tools for managing Google Docs | ||
Share Tools: Read Doc | ||
Share Tools: Read Google Doc, Update Google Doc |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Share Tools: Read Google Doc, Update Google Doc | |
Share Tools: Read Google Doc, Update Google Doc, Create Google Doc |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left this out on purpose because it's not really useful on its own.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added it to the bundle
google/docs/update_doc.py
Outdated
service.documents().batchUpdate( | ||
documentId=file_id, | ||
body={"requests": clear_requests} | ||
).execute() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we make both of these batch requests at once?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah, that's probably better. need to test if that causes issues with the doc indexing first.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've updated this to batch the clear request with the others.
1994186
to
a9a8415
Compare
yeah, I decided to keep it simple. I can add the feature if we really need it. |
Signed-off-by: Nick Hale <[email protected]>
a9a8415
to
3f27f67
Compare
Addresses obot-platform/obot#1406