Chore: Add openai o1 support #366
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StrongMonkey
requested review from
thedadams,
njhale,
sanjay920,
iwilltry42 and
g-linville
StrongMonkey
force-pushed
the
openai-o1
branch
2 times, most recently
from
4a4025b to
f0ab964
Compare
thedadams
reviewed
Jan 24, 2025
openai-model-provider/proxy/proxy.go
Outdated
| @@ -96,6 +101,41 @@ func (s *server) proxyDirector(req *http.Request) { | |||
| if s.cfg.PathPrefix != "" && !strings.HasPrefix(req.URL.Path, s.cfg.PathPrefix) { | |||
| req.URL.Path = s.cfg.PathPrefix + req.URL.Path | |||
| } | |||
|
|
|||
| if req.Body == nil || req.Method != http.MethodPost { | |||
There was a problem hiding this comment.
Does it make sense to do this?
Suggested change
| if req.Body == nil || req.Method != http.MethodPost { | |
| if req.Body == nil || s.cfg.UpstreamHost != "api.openai.com" || req.URL.Path != "/v1/chat/completion" { |
There was a problem hiding this comment.
I like this, because it means that we can look for errors when we try to unmarshal the body later.
There was a problem hiding this comment.
yep, I will change this.
Signed-off-by: Daishan Peng <[email protected]>
Signed-off-by: Daishan Peng <[email protected]>
StrongMonkey
force-pushed
the
openai-o1
branch
3 times, most recently
from
aa67dc3 to
bd15449
Compare
|
@thedadams Pushed a change that make the response compatiable with stream client in gptscript. |
StrongMonkey
commented
Jan 24, 2025
| return nil | ||
| } | ||
|
|
||
| func isModelO1(model string) bool { |
There was a problem hiding this comment.
The current PR only supports o1, as o1-mini doesn't seem to support system message which could screw a lot of things. We could investigate in a different issue.
StrongMonkey
force-pushed
the
openai-o1
branch
from
bd15449 to
5a2759d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add openai o1 support in proxy to modify request body.
obot-platform/obot#1131