enhance: enable js for google search tool #367
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
njhale
requested review from
drpebcak,
thedadams,
tybalex,
StrongMonkey,
iwilltry42 and
g-linville
ryanhopperlowe
approved these changes
Jan 24, 2025
google/search/src/search.ts
Outdated
| const foundURLs = new Set<string>() | ||
| const results: Array<Promise<SearchResult | null>> = [] | ||
|
|
||
| const page = await context.newPage() | ||
| const noJSPages = await Promise.all( | ||
| const pages = await Promise.all( | ||
| Array.from({ length: maxResults }, async () => { |
There was a problem hiding this comment.
nit: you can remove async/await from this since you're returning a promise from the array generator callback
const pages = await Promise.all(
Array.from({ length: maxResults }, () => context.newPage())
)There was a problem hiding this comment.
Thanks for the callout here. Fixed!
Enable Javascript when gathering page content in the `Google Search` tool. This allows more content to be extracted from web pages that require Javascript to load properly. Signed-off-by: Nick Hale <[email protected]>
njhale
force-pushed
the
enhance/google-search-enable-js
branch
from
c71af5e to
6cb3c5c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enable Javascript when gathering page content in the
Google Searchtool. This allows more content to be extracted from web pages that require Javascript to load properly.Addresses part of obot-platform/obot#1423