non-streaming DuckDBClient.query #1024
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mbostock
commented
Mar 8, 2024
| @@ -91,7 +91,7 @@ export class DuckDBClient { | |||
| throw error; | |||
| } | |||
| return { | |||
| schema: getArrowTableSchema(batch.value), | |||
| schema: batch.value.schema, | |||
There was a problem hiding this comment.
We’re now deviating from the DatabaseClient specification used in Observable notebooks, but I think it’s better to standardize on the Apache Arrow than our own specification. (Also this schema is unused in Framework — it exists in notebooks to power the data table cell, and we haven’t written than in Framework yet #23, but when we do, it should be based on the Apache Arrow schema.)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1016. Changes DuckDBClient.query to use
statement.queryorconnection.queryunder the hood, rather thanstatement.sendorconnection.send, which noticeably improves performance. In addition, returns an Arrow Table, rather than copying the results into an array of objects. Interactive SQL queries are faster!