fix react-dom@19 #1870
Closed
fix react-dom@19 #1870
+12
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
closes #1866
mbostock
reviewed
Dec 7, 2024
| return ( | ||
| name === "react" || | ||
| name === "react-dom" || | ||
| name === "react-dom/client" || |
There was a problem hiding this comment.
The /client would never be part of the name; it’s the path.
There was a problem hiding this comment.
true—I shouldn't have commited that part, it is for node and … I haven't found how to make it work (at all)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The root cause is facebook/react#28271 that was merged into version 19, which means we now have to pull in ReactDOM from "npm:react-dom/client" instead of "npm:react-dom".
This is (barely) documented in the release notes https://github.com/facebook/react/releases/tag/v19.0.0
From some manual testing, this PR is compatible with react-dom@18, but not @\17.
closes #1866