set context.path early #2252
Open
set context.path early #2252
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✅ |
This was referenced Nov 24, 2024
Merged
Draft
mbostock
requested changes
Nov 25, 2024
Fil
commented
Nov 25, 2024
Comment on lines
160
to
+165
| context.projection = createProjection(options, subdimensions); | ||
|
|
||
| // A path generator for marks that want to draw GeoJSON. | ||
| context.path = function () { | ||
| return geoPath(this.projection ?? xyProjection(scales)); | ||
| }; |
There was a problem hiding this comment.
Suggested change
| context.projection = createProjection(options, subdimensions); | |
| // A path generator for marks that want to draw GeoJSON. | |
| context.path = function () { | |
| return geoPath(this.projection ?? xyProjection(scales)); | |
| }; | |
| const projection = context.projection = createProjection(options, subdimensions); | |
| // A path generator for marks that want to draw GeoJSON. | |
| context.path = () => geoPath(projection ?? xyProjection(scales)); |
this is maybe more consistent?
mbostock
approved these changes
Nov 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Re: #2243 (comment)
My thinking initially was that we needed the scales to be ready, but in fact the position scales are ready when we create the context (initializers can set color, r, etc., but not x or y).
The centroid initializer now uses context.path. (The line mark render, and the link mark render, could already have used it before but I hadn't seen it; now they do, too.)
Note: currently legends create a context without passing the scales. They don't call context.path so it's not a problem, but if we wanted a legend to draw a geojson some time in the future, it would just have to pass scales.