Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Rk is backdrop modal widget impure validation haveibeenpwned #71

Conversation

cgibbard
Copy link
Collaborator

Some stuff that was in @eskimor 's repo

@eskimor
Copy link
Collaborator

eskimor commented Jun 28, 2019

Oh, this branch is just a combination of those already existing PRs:

#68
#67
#64

It just exists so we can use it on a client's project.

{
"owner": "bgamari",
"repo": "monoidal-containers",
"branch": "master",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might want to use my PR on this instead since it has some more fixes.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh, interesting

We're just shaving another yak right now actually, I should change the branch perhaps on my actual update branch, rather than this hasty merge of that and the branch we're using on interos... and/or I should review everything that's gone on here, and pull in the other direction.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR is all but merged by Ben: bgamari/monoidal-containers#41

@ali-abrar
Copy link
Member

Please update the changelog.

@cgibbard
Copy link
Collaborator Author

Ah, sorry! I didn't mean to edit this PR. I merged my other stuff into it so that we can attempt to update a client project.

@cgibbard
Copy link
Collaborator Author

I'll sort it out in a minute.

@cgibbard cgibbard changed the title Rk is backdrop modal widget impure validation haveibeenpwned WIP: Rk is backdrop modal widget impure validation haveibeenpwned Jun 28, 2019
@cgibbard cgibbard closed this Jun 29, 2019
@ali-abrar ali-abrar deleted the rk-is-backdrop-modal-widget-impure-validation-haveibeenpwned branch November 20, 2021 19:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants