Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix OnAcceleratedPaint2() not being called when there's no new texture #1

Open
wants to merge 1 commit into
base: 5060-shared-textures
Choose a base branch
from
Open

Fix OnAcceleratedPaint2() not being called when there's no new texture #1

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Fix OnAcceleratedPaint2() not being called when there's no new texture
  • Loading branch information
@elvissteinjr
elvissteinjr committed Aug 13, 2022
commit ad0e0e737f43e863dc98a0ebb42ab21cb20fcb3f
6 changes: 2 additions & 4 deletions libcef_dll/cpptoc/render_handler_cpptoc.cc
View file
Original file line number Diff line number Diff line change
@@ -339,8 +339,6 @@ render_handler_on_accelerated_paint2(struct _cef_render_handler_t* self,
int new_texture) {
shutdown_checker::AssertNotShutdown();

// AUTO-GENERATED CONTENT - DELETE THIS COMMENT BEFORE MODIFYING

DCHECK(self);
if (!self)
return;
@@ -353,8 +351,8 @@ render_handler_on_accelerated_paint2(struct _cef_render_handler_t* self,
if (dirtyRectsCount > 0 && !dirtyRects)
return;
// Verify param: shared_handle; type: simple_byaddr
DCHECK(shared_handle);
if (!shared_handle)
DCHECK(!new_texture || shared_handle);
if (new_texture && !shared_handle)
return;

// Translate param: dirtyRects; type: simple_vec_byref_const
6 changes: 2 additions & 4 deletions libcef_dll/ctocpp/render_handler_ctocpp.cc
View file
Original file line number Diff line number Diff line change
@@ -277,15 +277,13 @@ void CefRenderHandlerCToCpp::OnAcceleratedPaint2(CefRefPtr<CefBrowser> browser,
if (CEF_MEMBER_MISSING(_struct, on_accelerated_paint2))
return;

// AUTO-GENERATED CONTENT - DELETE THIS COMMENT BEFORE MODIFYING

// Verify param: browser; type: refptr_diff
DCHECK(browser.get());
if (!browser.get())
return;
// Verify param: shared_handle; type: simple_byaddr
DCHECK(shared_handle);
if (!shared_handle)
DCHECK(!new_texture || shared_handle);
if (new_texture && !shared_handle)
return;

// Translate param: dirtyRects; type: simple_vec_byref_const