Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Elgato submodule to use NOMINMAX #59

Merged
merged 1 commit into from
Feb 7, 2025

Conversation

RytoEX
Copy link
Member

@RytoEX RytoEX commented Feb 6, 2025

Description

Update the Elgato submodule to use NOMINMAX and std::min explicitly.

Motivation and Context

Necessary for WoA, and we should be using NOMINMAX anywhere possible anyway. This should help land obsproject/obs-studio#11385.

Note that consumers that already set NOMINMAX may have to suppress C4005 (macro redefinition warning) until the macro definition is guarded in elgatosf/capture-device-support#8.

How Has This Been Tested?

Compiled locally on Windows 11 with VS 2022.

Types of changes

  • Tweak (non-breaking change to improve existing functionality)

Checklist:

  • My code has been run through clang-format.
  • I have read the contributing document.
  • My code is not on the master branch.
  • The code has been tested.
  • All commit messages are properly formatted and commits squashed where appropriate.
  • I have included updates to all appropriate documentation.

Use NOMINMAX and std::min explicitly.
@RytoEX RytoEX requested a review from PatTheMav February 6, 2025 20:01
@RytoEX RytoEX self-assigned this Feb 6, 2025
@RytoEX RytoEX merged commit 8878638 into obsproject:master Feb 7, 2025
@RytoEX RytoEX deleted the use-nominmax branch February 7, 2025 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants