win-capture: Update hooked state before unhooked signal #10460
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EZ64cool
force-pushed
the
game-capture-get-hooked-after-unhooked-fix
branch
from
f88307a to
a504a8b
Compare
RytoEX
requested changes
Mar 30, 2024
EZ64cool
force-pushed
the
game-capture-get-hooked-after-unhooked-fix
branch
from
a504a8b to
6cde4b1
Compare
EZ64cool
changed the title
|
In the commit message of 6cde4b1, the 2nd line is not empty. |
EZ64cool
force-pushed
the
game-capture-get-hooked-after-unhooked-fix
branch
2 times, most recently
from
36ce5c5 to
e17697f
Compare
|
Hey, any chance this could make it in? It's stopped me from using signals and I'm instead spinning up my own update thread to query the state, which feels a bit overkill for what I need. |
EZ64cool
force-pushed
the
game-capture-get-hooked-after-unhooked-fix
branch
from
1390258 to
dfaa7f0
Compare
|
Hey @RytoEX sorry to necro this but I just spent some time updating this to latest. I think your review is the last thing blocking this, if you wouldn't mind taking a look again. Thanks. |
If the get_hooked procedure is called during the unhooked signal the source would still report that it's hooked because gc->capturing hasn't been updated yet.
EZ64cool
force-pushed
the
game-capture-get-hooked-after-unhooked-fix
branch
from
dfaa7f0 to
fd9f8a9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Move the game-capture's
gc->capturing = falseupdate to before the unhooked signal is sent. This replicates the behaviour of window-capture.Motivation and Context
If the get_hooked procedure is called during the unhooked signal the source would still report that it's hooked because
gc->capturinghasn't been updated yet.How Has This Been Tested?
Tested on windows 10 x64 and it now works as expected. It's a very isolated change so easy to test.
Types of changes
Checklist: