linux-pipewire: Use list-based format selector for video capture #11741
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tytan652
added
Bug Fix
tytan652
force-pushed
the
improve_pw_camera_ux
branch
from
1fdcb9b to
65891c4
Compare
tytan652
added
the
UI/UX
|
We had a lot of discussion about the string formatting for #10895 so I'd like to copy that as closely as possible for this. |
Warchamp7
approved these changes
Jan 27, 2025
Negotiation is now made with the user selected format. Also fixes a typo in the name of a structure.
tytan652
force-pushed
the
improve_pw_camera_ux
branch
from
65891c4 to
9ae7734
Compare
Lain-B
reviewed
Feb 3, 2025
| uint32_t n_framerates; | ||
| enum spa_choice_type framerate_choice; | ||
| const struct spa_fraction *framerate_values; | ||
| g_autoptr(GArray) framerates = NULL; |
There was a problem hiding this comment.
The code above this line feels just a little bit squished. Doesn't particularly matter though I suppose.
There was a problem hiding this comment.
Added a new line before the framerate related variable from the second commit.
But many variable/pointer is expected from PipeWire/SPA API when you parse properties.
tytan652
force-pushed
the
improve_pw_camera_ux
branch
from
9ae7734 to
f7f7068
Compare
6 tasks
|
@Warchamp7 does this now copy #10895 as closely as possible to be acceptable? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Change the video capture source UX to choose between formats provided as is by PipeWire and avoid providing non-functional combination.
Also it avoid the user to check every format to find the right resolution.
Negotiation is now made with the user selected format (the choice was ignored before).
Also fixes a typo in the name of a structure.
Note
Formatting of the strings case can be discussed, and FPS values (mainly multiple choices per format) could be added.
Before:
After first commit:
After second commit:
Motivation and Context
Inspired by #10895 and the fact the actual code was not respecting the user chosen format and potentially showing non-available resolution for some formats.
How Has This Been Tested?
Types of changes
Checklist: