Config: Ensure conversion to filesystem::path uses utf-8 #1231
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Use
u8pathto construct thestd::filesystem::pathto ensure the string is correctly treated as UTF-8.Motivation and Context
Fixes crash on startup if OBS is installed on non-English systems.
How Has This Been Tested?
Tested on a Windows VM with a user named
くそ, while I could not reproduce the crash, I could reproduce the plugin not loading due to the migration failing. With this patch it worked and loaded up normally.Types of changes
Checklist:
masteror arelease/*branch.