Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix profile functions that direct call a method instead of the API #1265

Merged
merged 4 commits into from
Oct 29, 2024

Conversation

BarryCarlyon
Copy link
Contributor

@BarryCarlyon BarryCarlyon commented Oct 23, 2024

Description

Fixes #1264

This just updates the function name invoked to the new one outlined in obsproject/obs-studio@b9808ea

Conceptually to prevent this fault in future should move to obs_frontend_create_profile instead?

Move create and delete profile to their API functions instead

Motivation and Context

WebSocket function for CreateProfile is not working in 31 beta due to internal function rename and not using an API function

How Has This Been Tested?

Tested OS(s):

Types of changes

Checklist:

  • I have read the Contributing Guidelines.
  • All commit messages are properly formatted and commits squashed where appropriate.
  • My code is not on master or a release/* branch.
  • The code has been tested.
  • I have included updates to all appropriate documentation.

@RytoEX RytoEX requested review from tt2468 and PatTheMav October 24, 2024 00:43
@RytoEX RytoEX self-assigned this Oct 24, 2024
@BarryCarlyon BarryCarlyon changed the title Fix Create Profile function Fix profile functions that direct call a method instead of the API Oct 24, 2024
@RytoEX RytoEX merged commit 702bb0c into obsproject:master Oct 29, 2024
1 check passed
@RytoEX
Copy link
Member

RytoEX commented Oct 29, 2024

In hindsight, these commits should have been squashed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: cannot create new profile in the beta for 31
3 participants