fix: character change does not persist after save. #1749
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
faucomte97
approved these changes
Nov 22, 2024
There was a problem hiding this comment.
Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @Ridwanah)
|
@Ridwanah thanks for your solution, it looks good so I will go ahead and merge your PR now 🙂 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I fixed the issue where a character change in the level editor would not appear in the character tab and would default to the van option.
This happened because the restoreState function was trying to get the character id from saved level, but it was the character name that was saved not the id. I changed this by getting the character id from the saved character name.
How Has This Been Tested?
I tested this using pytest and all the tests passed.
I also tested it by creating new levels in the level editor and checking if the change is there.
Checklist:
This change is