Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release Caqti 1.9.0. #22070

Merged
merged 1 commit into from
Sep 8, 2022
Merged

Release Caqti 1.9.0. #22070

merged 1 commit into from
Sep 8, 2022

Conversation

paurkedal
Copy link
Contributor

I would like to make a new Caqti release including a few feature and bug fixes (release notes).

@paurkedal
Copy link
Contributor Author

I can see the lower bounds (at least) need some work. I'll take a closer look in the evening.

@paurkedal
Copy link
Contributor Author

paurkedal commented Sep 7, 2022

Here is my take at the remaining CI errors:

  • (compilers 4.05) There is some build error for cppo on ocaml-4.05. Not sure, but could be it needs a newer dune/jbuild.
  • (compilers 4.14) ppx_rapper.3.1.0 (and later) should depend on caqti {>= "1.7.0"}. The other Caqti dependencies should not need such a constraint. (Reported upstream: Need Lower Bound on the Caqti Dependencies roddyyaga/ppx_rapper#26).
  • (compilers 5.0) The mariadb is caused by the use of Stream in the setup.ml script, so it's probably an oasis issue.
  • (compilers 5.0) Old versions of sqlite3 will need an upper compiler bound due to String.lowercase usage.
  • The remaining looks like CI problems.

mseri added a commit that referenced this pull request Sep 8, 2022
Otherwise fails with 
```
#=== ERROR while compiling ppx_rapper_lwt.3.1.0 ===============================#
# context              2.2.0~alpha~dev | linux/x86_64 | ocaml-base-compiler.4.14.0 | file:///home/opam/opam-repository
# path                 ~/.opam/4.14/.opam-switch/build/ppx_rapper_lwt.3.1.0
# command              ~/.opam/opam-init/hooks/sandbox.sh build dune build -p ppx_rapper_lwt -j 31 @install @runtest
# exit-code            1
# env-file             ~/.opam/log/ppx_rapper_lwt-7-4f659c.env
# output-file          ~/.opam/log/ppx_rapper_lwt-7-4f659c.out
### output ###
# (cd _build/default && /home/opam/.opam/4.14/bin/ocamlc.opt -w -40 -g -bin-annot -I test/runtime/.test_compiles.eobjs/byte -I /home/opam/.opam/4.14/lib/angstrom -I /home/opam/.opam/4.14/lib/base -I /home/opam/.opam/4.14/lib/base/base_internalhash_types -I /home/opam/.opam/4.14/lib/base/caml -I /home/opam/.opam/4.14/lib/base/shadow_stdlib -I /home/opam/.opam/4.14/lib/bigstringaf -I /home/opam/.opam/4.14/lib/calendar -I /home/opam/.opam/4.14/lib/caqti -I /home/opam/.opam/4.14/lib/caqti-lwt -I /home/opam/.opam/4.14/lib/caqti-type-calendar -I /home/opam/.opam/4.14/lib/logs -I /home/opam/.opam/4.14/lib/lwt -I /home/opam/.opam/4.14/lib/lwt/unix -I /home/opam/.opam/4.14/lib/ocaml/threads -I /home/opam/.opam/4.14/lib/ocplib-endian -I /home/opam/.opam/4.14/lib/ocplib-endian/bigstring -I /home/opam/.opam/4.14/lib/ppx_deriving/runtime -I /home/opam/.opam/4.14/lib/ppx_rapper/runtime -I /home/opam/.opam/4.14/lib/ptime -I /home/opam/.opam/4.14/lib/result -I /home/opam/.opam/4.14/lib/sexplib0 -I /home/opam/.opam/4.14/lib/stringext -I /home/opam/.opam/4.14/lib/uri -I lib-lwt/.ppx_rapper_lwt.objs/byte -no-alias-deps -open Dune__exe -o test/runtime/.test_compiles.eobjs/byte/dune__exe__Test_compiles_base.cmo -c -impl test/runtime/test_compiles_base.pp.ml)
# File "test/runtime/test_compiles_base.ml", lines 8-14, characters 2-12:
#  8 | ..[%rapper
#  9 |     execute
# 10 |       {sql|
# 11 |       UPDATE users
# 12 |       SET (username, email, bio) = (%string{username}, %string{email}, %string?{bio})
# 13 |       WHERE id = %int{id}
# 14 |       |sql}]
# Error: Unbound module Caqti_request.Infix
# (cd _build/default && /home/opam/.opam/4.14/bin/ocamlc.opt -w -40 -g -bin-annot -I test/runtime/.test_compiles.eobjs/byte -I /home/opam/.opam/4.14/lib/angstrom -I /home/opam/.opam/4.14/lib/base -I /home/opam/.opam/4.14/lib/base/base_internalhash_types -I /home/opam/.opam/4.14/lib/base/caml -I /home/opam/.opam/4.14/lib/base/shadow_stdlib -I /home/opam/.opam/4.14/lib/bigstringaf -I /home/opam/.opam/4.14/lib/calendar -I /home/opam/.opam/4.14/lib/caqti -I /home/opam/.opam/4.14/lib/caqti-lwt -I /home/opam/.opam/4.14/lib/caqti-type-calendar -I /home/opam/.opam/4.14/lib/logs -I /home/opam/.opam/4.14/lib/lwt -I /home/opam/.opam/4.14/lib/lwt/unix -I /home/opam/.opam/4.14/lib/ocaml/threads -I /home/opam/.opam/4.14/lib/ocplib-endian -I /home/opam/.opam/4.14/lib/ocplib-endian/bigstring -I /home/opam/.opam/4.14/lib/ppx_deriving/runtime -I /home/opam/.opam/4.14/lib/ppx_rapper/runtime -I /home/opam/.opam/4.14/lib/ptime -I /home/opam/.opam/4.14/lib/result -I /home/opam/.opam/4.14/lib/sexplib0 -I /home/opam/.opam/4.14/lib/stringext -I /home/opam/.opam/4.14/lib/uri -I lib-lwt/.ppx_rapper_lwt.objs/byte -no-alias-deps -open Dune__exe -o test/runtime/.test_compiles.eobjs/byte/dune__exe__Test_compiles.cmo -c -impl test/runtime/test_compiles.pp.ml)
# File "test/runtime/test_compiles.ml", lines 6-12, characters 2-12:
#  6 | ..[%rapper
#  7 |     execute
#  8 |       {sql|
#  9 |       UPDATE users
# 10 |       SET (username, email, bio) = (%string{username}, %string{email}, %string?{bio})
# 11 |       WHERE id = %int{id}
# 12 |       |sql}]
# Error: Unbound module Caqti_request.Infix
```
Seen on #22070
mseri added a commit that referenced this pull request Sep 8, 2022
The setup.ml file uses String.lowercase
```
#=== ERROR while compiling sqlite3.3.0.0 ======================================#
# context              2.2.0~alpha~dev | linux/x86_64 | ocaml-variants.5.0.0+trunk | file:///home/opam/opam-repository
# path                 ~/.opam/5.0/.opam-switch/build/sqlite3.3.0.0
# command              ~/.opam/opam-init/hooks/sandbox.sh build ocaml setup.ml -configure --prefix /home/opam/.opam/5.0
# exit-code            2
# env-file             ~/.opam/log/sqlite3-7-688af9.env
# output-file          ~/.opam/log/sqlite3-7-688af9.out
### output ###
# File "./setup.ml", line 318, characters 20-36:
# 318 |     String.compare (String.lowercase s1) (String.lowercase s2)
#                           ^^^^^^^^^^^^^^^^
# Error: Unbound value String.lowercase
```
Seen on #22070
@mseri mseri merged commit 0814b1f into ocaml:master Sep 8, 2022
@mseri
Copy link
Member

mseri commented Sep 8, 2022

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants