-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release Caqti 1.9.0. #22070
Merged
Merged
Release Caqti 1.9.0. #22070
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I can see the lower bounds (at least) need some work. I'll take a closer look in the evening. |
paurkedal
force-pushed
the
caqti.1.9.0
branch
from
September 6, 2022 17:28
34f1e15
to
10f3012
Compare
Here is my take at the remaining CI errors:
|
mseri
added a commit
that referenced
this pull request
Sep 8, 2022
Otherwise fails with ``` #=== ERROR while compiling ppx_rapper_lwt.3.1.0 ===============================# # context 2.2.0~alpha~dev | linux/x86_64 | ocaml-base-compiler.4.14.0 | file:///home/opam/opam-repository # path ~/.opam/4.14/.opam-switch/build/ppx_rapper_lwt.3.1.0 # command ~/.opam/opam-init/hooks/sandbox.sh build dune build -p ppx_rapper_lwt -j 31 @install @runtest # exit-code 1 # env-file ~/.opam/log/ppx_rapper_lwt-7-4f659c.env # output-file ~/.opam/log/ppx_rapper_lwt-7-4f659c.out ### output ### # (cd _build/default && /home/opam/.opam/4.14/bin/ocamlc.opt -w -40 -g -bin-annot -I test/runtime/.test_compiles.eobjs/byte -I /home/opam/.opam/4.14/lib/angstrom -I /home/opam/.opam/4.14/lib/base -I /home/opam/.opam/4.14/lib/base/base_internalhash_types -I /home/opam/.opam/4.14/lib/base/caml -I /home/opam/.opam/4.14/lib/base/shadow_stdlib -I /home/opam/.opam/4.14/lib/bigstringaf -I /home/opam/.opam/4.14/lib/calendar -I /home/opam/.opam/4.14/lib/caqti -I /home/opam/.opam/4.14/lib/caqti-lwt -I /home/opam/.opam/4.14/lib/caqti-type-calendar -I /home/opam/.opam/4.14/lib/logs -I /home/opam/.opam/4.14/lib/lwt -I /home/opam/.opam/4.14/lib/lwt/unix -I /home/opam/.opam/4.14/lib/ocaml/threads -I /home/opam/.opam/4.14/lib/ocplib-endian -I /home/opam/.opam/4.14/lib/ocplib-endian/bigstring -I /home/opam/.opam/4.14/lib/ppx_deriving/runtime -I /home/opam/.opam/4.14/lib/ppx_rapper/runtime -I /home/opam/.opam/4.14/lib/ptime -I /home/opam/.opam/4.14/lib/result -I /home/opam/.opam/4.14/lib/sexplib0 -I /home/opam/.opam/4.14/lib/stringext -I /home/opam/.opam/4.14/lib/uri -I lib-lwt/.ppx_rapper_lwt.objs/byte -no-alias-deps -open Dune__exe -o test/runtime/.test_compiles.eobjs/byte/dune__exe__Test_compiles_base.cmo -c -impl test/runtime/test_compiles_base.pp.ml) # File "test/runtime/test_compiles_base.ml", lines 8-14, characters 2-12: # 8 | ..[%rapper # 9 | execute # 10 | {sql| # 11 | UPDATE users # 12 | SET (username, email, bio) = (%string{username}, %string{email}, %string?{bio}) # 13 | WHERE id = %int{id} # 14 | |sql}] # Error: Unbound module Caqti_request.Infix # (cd _build/default && /home/opam/.opam/4.14/bin/ocamlc.opt -w -40 -g -bin-annot -I test/runtime/.test_compiles.eobjs/byte -I /home/opam/.opam/4.14/lib/angstrom -I /home/opam/.opam/4.14/lib/base -I /home/opam/.opam/4.14/lib/base/base_internalhash_types -I /home/opam/.opam/4.14/lib/base/caml -I /home/opam/.opam/4.14/lib/base/shadow_stdlib -I /home/opam/.opam/4.14/lib/bigstringaf -I /home/opam/.opam/4.14/lib/calendar -I /home/opam/.opam/4.14/lib/caqti -I /home/opam/.opam/4.14/lib/caqti-lwt -I /home/opam/.opam/4.14/lib/caqti-type-calendar -I /home/opam/.opam/4.14/lib/logs -I /home/opam/.opam/4.14/lib/lwt -I /home/opam/.opam/4.14/lib/lwt/unix -I /home/opam/.opam/4.14/lib/ocaml/threads -I /home/opam/.opam/4.14/lib/ocplib-endian -I /home/opam/.opam/4.14/lib/ocplib-endian/bigstring -I /home/opam/.opam/4.14/lib/ppx_deriving/runtime -I /home/opam/.opam/4.14/lib/ppx_rapper/runtime -I /home/opam/.opam/4.14/lib/ptime -I /home/opam/.opam/4.14/lib/result -I /home/opam/.opam/4.14/lib/sexplib0 -I /home/opam/.opam/4.14/lib/stringext -I /home/opam/.opam/4.14/lib/uri -I lib-lwt/.ppx_rapper_lwt.objs/byte -no-alias-deps -open Dune__exe -o test/runtime/.test_compiles.eobjs/byte/dune__exe__Test_compiles.cmo -c -impl test/runtime/test_compiles.pp.ml) # File "test/runtime/test_compiles.ml", lines 6-12, characters 2-12: # 6 | ..[%rapper # 7 | execute # 8 | {sql| # 9 | UPDATE users # 10 | SET (username, email, bio) = (%string{username}, %string{email}, %string?{bio}) # 11 | WHERE id = %int{id} # 12 | |sql}] # Error: Unbound module Caqti_request.Infix ``` Seen on #22070
mseri
added a commit
that referenced
this pull request
Sep 8, 2022
The setup.ml file uses String.lowercase ``` #=== ERROR while compiling sqlite3.3.0.0 ======================================# # context 2.2.0~alpha~dev | linux/x86_64 | ocaml-variants.5.0.0+trunk | file:///home/opam/opam-repository # path ~/.opam/5.0/.opam-switch/build/sqlite3.3.0.0 # command ~/.opam/opam-init/hooks/sandbox.sh build ocaml setup.ml -configure --prefix /home/opam/.opam/5.0 # exit-code 2 # env-file ~/.opam/log/sqlite3-7-688af9.env # output-file ~/.opam/log/sqlite3-7-688af9.out ### output ### # File "./setup.ml", line 318, characters 20-36: # 318 | String.compare (String.lowercase s1) (String.lowercase s2) # ^^^^^^^^^^^^^^^^ # Error: Unbound value String.lowercase ``` Seen on #22070
Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I would like to make a new Caqti release including a few feature and bug fixes (release notes).