Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[new release] reason-react (2 packages) (0.14.0) #25227

Merged
merged 6 commits into from
Feb 27, 2024

Conversation

davesnx
Copy link
Contributor

@davesnx davesnx commented Feb 10, 2024

Reason bindings for React.js

CHANGES:

CHANGES:

* Wrap the `React` library, exposing just a single top-level module
  (@anmonteiro in [reasonml/reason-react#783](reasonml/reason-react#783))
* Re-organise toplevel modules (@davesnx in [reasonml/reason-react#794](reasonml/reason-react#794))
* Require and adapt to Melange v3 (@anmonteiro in [reasonml/reason-react#821](reasonml/reason-react#821))
@anmonteiro
Copy link
Contributor

took care of the revdeps issues here: #25230

@avsm
Copy link
Member

avsm commented Feb 19, 2024

Looks like a few test dependencies are missing here.

#=== ERROR while compiling reason-react-ppx.0.14.0 ============================#
# context              2.2.0~beta2~dev | linux/x86_64 | ocaml-base-compiler.5.1.1 | pinned(https://github.com/reasonml/reason-react/releases/download/0.14.0/reason-react-0.14.0.tbz)
# path                 ~/.opam/5.1/.opam-switch/build/reason-react-ppx.0.14.0
# command              ~/.opam/opam-init/hooks/sandbox.sh build dune build -p reason-react-ppx -j 255 @install @runtest
# exit-code            1
# env-file             ~/.opam/log/reason-react-ppx-7-490676.env
# output-file          ~/.opam/log/reason-react-ppx-7-490676.out
### output ###
# File "ppx/test/dune", line 4, characters 11-23:
# 4 |   (package reason-react)
#                ^^^^^^^^^^^^
# Error: Package reason-react does not exist
# File "ppx/test/dune", line 8, characters 2-11:
# 8 |   %{bin:jq}
#       ^^^^^^^^^
# Error: Program jq not found in the tree or in PATH
#  (context: default)
# File "test/dune", line 6, characters 48-60:
# 6 |  (libraries reason-react reason-react.node jest melange.belt)
#                                                     ^^^^^^^^^^^^
# Error: Library "melange.belt" not found.
# -> required by alias test/runtest

@davesnx
Copy link
Contributor Author

davesnx commented Feb 21, 2024

Sure, tests aren't meant to run on the opam-repository since #24422 (comment)

…se-reason-react-0.14.0

* 'master' of github.com:/ocaml/opam-repository: (135 commits)
  ez-conf-lib.2
  Update opam
  Update opam
  [new release] reason (2 packages) (3.11.0)
  2 packages from extism/ocaml-sdk at 1.1.0
  lintcstubs-arity is not compatible with OCaml 5.2 (uses compiler-libs)
  multipart_form-lwt: Disable the tests on OCaml 5.2 (\r\n are now parsed differently)
  multipart_form: Disable the tests on OCaml 5.2 (\r\n are now parsed differently)
  mrmime: Disable the tests on OCaml 5.2 (\r\n are now parsed differently)
  unstrctrd: Disable the tests on OCaml 5.2 (\r\n are now parsed differently)
  pecu.0.6: Disable the tests on OCaml 5.2 (\r\n are now parsed differently)
  Update packages/memprof-limits/memprof-limits.0.2.0/opam
  Update the OCaml 5.2 preview for merlin
  [new release] printbox (4 packages) (0.10)
  memprof-limits is not compatible with OCaml 5.2 (changes in Stdlib.Gc)
  [new release] eio (5 packages) (0.15)
  melange is not compatible with OCaml 5.2 (uses compiler-libs)
  ocamlformat-lib is not compatible with OCaml 5.2 (uses compiler-libs)
  reason is not compatible with OCaml 5.2 (uses compiler-libs)
  [new release] merlin-lib, merlin (4.14-501/500/414)
  ...
@davesnx
Copy link
Contributor Author

davesnx commented Feb 27, 2024

This is ready to review @mseri

@mseri
Copy link
Member

mseri commented Feb 27, 2024

lgtm

@mseri mseri merged commit 0dfc0ed into ocaml:master Feb 27, 2024
2 checks passed
@mseri
Copy link
Member

mseri commented Feb 27, 2024

thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants