Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[new release] coq-lsp (0.2.2+8.19) #26673

Merged
merged 1 commit into from
Oct 7, 2024

Conversation

ejgallego
Copy link
Contributor

Language Server Protocol native server for Coq

CHANGES:

CHANGES:

---------------------------------------------

 - [vscode] Expand selectors to include `vscode-vfs://` URIs used in
   `github.dev`, document limited virtual workspace support in
   `package.json` (@ejgallego, ejgallego/coq-lsp#849)
@ejgallego
Copy link
Contributor Author

ejgallego commented Oct 5, 2024

CI seems fine:

@mseri
Copy link
Member

mseri commented Oct 7, 2024

@dkalinichenko-js ppx_globalize v0.17 is failing with ocaml 5.3:

#=== ERROR while compiling ppx_globalize.v0.17.0 ==============================#
# context              2.4.0~alpha1~dev | linux/x86_64 | ocaml-base-compiler.5.3.0~alpha1 | file:///home/opam/opam-repository
# path                 ~/.opam/5.3~alpha1/.opam-switch/build/ppx_globalize.v0.17.0
# command              ~/.opam/opam-init/hooks/sandbox.sh build dune build -p ppx_globalize -j 39
# exit-code            1
# env-file             ~/.opam/log/ppx_globalize-7-e36d94.env
# output-file          ~/.opam/log/ppx_globalize-7-e36d94.out
### output ###
# (cd _build/default && /home/opam/.opam/5.3~alpha1/bin/ocamlc.opt -w -40 -g -bin-annot -bin-annot-occurrences -I .ppx_globalize.objs/byte -I /home/opam/.opam/5.3~alpha1/lib/base -I /home/opam/.opam/5.3~alpha1/lib/base/base_internalhash_types -I /home/opam/.opam/5.3~alpha1/lib/base/shadow_stdlib -I /home/opam/.opam/5.3~alpha1/lib/ocaml-compiler-libs/common -I /home/opam/.opam/5.3~alpha1/lib/ocaml-compiler-libs/shadow -I /home/opam/.opam/5.3~alpha1/lib/ocaml/compiler-libs -I /home/opam/.opam/5.3~alpha1/lib/ocaml_intrinsics_kernel -I /home/opam/.opam/5.3~alpha1/lib/ppx_derivers -I /home/opam/.opam/5.3~alpha1/lib/ppxlib -I /home/opam/.opam/5.3~alpha1/lib/ppxlib/ast -I /home/opam/.opam/5.3~alpha1/lib/ppxlib/astlib -I /home/opam/.opam/5.3~alpha1/lib/ppxlib/print_diff -I /home/opam/.opam/5.3~alpha1/lib/ppxlib/stdppx -I /home/opam/.opam/5.3~alpha1/lib/ppxlib/traverse_builtins -I /home/opam/.opam/5.3~alpha1/lib/ppxlib_jane -I /home/opam/.opam/5.3~alpha1/lib/sexplib0 -I /home/opam/.opam/5.3~alpha1/lib/stdlib-shims -intf-suffix .ml -no-alias-deps -o .ppx_globalize.objs/byte/ppx_globalize.cmo -c -impl ppx_globalize.pp.ml)
# File "ppx_globalize.ml", line 20, characters 11-73:
# 20 |     (match Ppxlib_jane.Ast_builder.Default.get_label_declaration_modality ld with
#                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
# Error: Unbound value "Ppxlib_jane.Ast_builder.Default.get_label_declaration_modality"
# Hint: Did you mean "get_label_declaration_modalities"?
# (cd _build/default && /home/opam/.opam/5.3~alpha1/bin/ocamlopt.opt -w -40 -g -I .ppx_globalize.objs/byte -I .ppx_globalize.objs/native -I /home/opam/.opam/5.3~alpha1/lib/base -I /home/opam/.opam/5.3~alpha1/lib/base/base_internalhash_types -I /home/opam/.opam/5.3~alpha1/lib/base/shadow_stdlib -I /home/opam/.opam/5.3~alpha1/lib/ocaml-compiler-libs/common -I /home/opam/.opam/5.3~alpha1/lib/ocaml-compiler-libs/shadow -I /home/opam/.opam/5.3~alpha1/lib/ocaml/compiler-libs -I /home/opam/.opam/5.3~alpha1/lib/ocaml_intrinsics_kernel -I /home/opam/.opam/5.3~alpha1/lib/ppx_derivers -I /home/opam/.opam/5.3~alpha1/lib/ppxlib -I /home/opam/.opam/5.3~alpha1/lib/ppxlib/ast -I /home/opam/.opam/5.3~alpha1/lib/ppxlib/astlib -I /home/opam/.opam/5.3~alpha1/lib/ppxlib/print_diff -I /home/opam/.opam/5.3~alpha1/lib/ppxlib/stdppx -I /home/opam/.opam/5.3~alpha1/lib/ppxlib/traverse_builtins -I /home/opam/.opam/5.3~alpha1/lib/ppxlib_jane -I /home/opam/.opam/5.3~alpha1/lib/sexplib0 -I /home/opam/.opam/5.3~alpha1/lib/stdlib-shims -intf-suffix .ml -no-alias-deps -o .ppx_globalize.objs/native/ppx_globalize.cmx -c -impl ppx_globalize.pp.ml)
# File "ppx_globalize.ml", line 20, characters 11-73:
# 20 |     (match Ppxlib_jane.Ast_builder.Default.get_label_declaration_modality ld with
#                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
# Error: Unbound value "Ppxlib_jane.Ast_builder.Default.get_label_declaration_modality"
# Hint: Did you mean "get_label_declaration_modalities"?

I am pinging you FYI

@ejgallego I am going to proceed with the merge since the failures are due to dependencies

@mseri mseri merged commit 384d468 into ocaml:master Oct 7, 2024
1 of 3 checks passed
@ejgallego ejgallego deleted the release-coq-lsp-0.2.2+8.19 branch October 7, 2024 20:28
@ejgallego
Copy link
Contributor Author

@ejgallego I am going to proceed with the merge since the failures are due to dependencies

Thanks! Indeed the CI failure was unrelated.

The Windows failures are due to ocamlfind so it'd be nice if we could do a release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants