-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upper bounds for cohttp 6 #26969
Merged
Merged
Upper bounds for cohttp 6 #26969
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fails with ``` === ERROR while compiling ldp_curl.0.3.0 =====================================# context 2.4.0~alpha1~dev | linux/x86_64 | ocaml-base-compiler.4.14.2 | file:///home/opam/opam-repository path ~/.opam/4.14/.opam-switch/build/ldp_curl.0.3.0 command ~/.opam/opam-init/hooks/sandbox.sh build dune build -p ldp_curl -j 39 --promote-install-files=false @install exit-code 1 env-file ~/.opam/log/ldp_curl-7-93e790.env output-file ~/.opam/log/ldp_curl-7-93e790.out (cd _build/default && /home/opam/.opam/4.14/bin/ocamlopt.opt -g -w -40 -w -6-7-9-10-27-32-33-34-35-36-50-52 -no-strict-sequence -g -I curl/.ldp_curl.objs/byte -I curl/.ldp_curl.objs/native -I /home/opam/.opam/4.14/lib/angstrom -I /home/opam/.opam/4.14/lib/base64 -I /home/opam/.opam/4.14/lib/bigstringaf -I /home/opam/.opam/4.14/lib/bytes -I /home/opam/.opam/4.14/lib/cohttp -I /home/opam/.opam/4.14/lib/cohttp-lwt -I /home/opam/.opam/4.14/lib/curl -I /home/opam/.opam/4.14/lib/dune-build-info -I /home/opam/.opam/4.14/lib/fmt -I /home/opam/.opam/4.14/lib/gen -I /home/opam/.opam/4.14/lib/http -I /home/opam/.opam/4.14/lib/http/__private__/http_bytebuffer -I /home/opam/.opam/4.14/lib/iri -I /home/opam/.opam/4.14/lib/ldp -I /home/opam/.opam/4.14/lib/logs -I /home/opam/.opam/4.14/lib/lwt -I /home/opam/.opam/4.14/lib/lwt/unix -I /home/opam/.opam/4.14/lib/menhirLib -I /home/opam/.opam/4.14/lib/ocaml/threads -I /home/opam/.opam/4.14/lib/ocf -I /home/opam/.opam/4.14/lib/ocplib-endian -I /home/opam/.opam/4.14/lib/ocplib-endian/bigstring -I /home/opam/.opam/4.14/lib/pcre -I /home/opam/.opam/4.14/lib/ppx_sexp_conv/runtime-lib -I /home/opam/.opam/4.14/lib/ptime -I /home/opam/.opam/4.14/lib/rdf -I /home/opam/.opam/4.14/lib/re -I /home/opam/.opam/4.14/lib/re/str -I /home/opam/.opam/4.14/lib/sedlex -I /home/opam/.opam/4.14/lib/seq -I /home/opam/.opam/4.14/lib/sexplib0 -I /home/opam/.opam/4.14/lib/stringext -I /home/opam/.opam/4.14/lib/uri -I /home/opam/.opam/4.14/lib/uri-sexp -I /home/opam/.opam/4.14/lib/uucp -I /home/opam/.opam/4.14/lib/uuidm -I /home/opam/.opam/4.14/lib/uunf -I /home/opam/.opam/4.14/lib/uutf -I /home/opam/.opam/4.14/lib/xmlm -I /home/opam/.opam/4.14/lib/yojson -intf-suffix .ml -no-alias-deps -o curl/.ldp_curl.objs/native/ldp_curl.cmx -c -impl curl/ldp_curl.pp.ml) File "curl/ldp_curl.ml", line 61, characters 22-42: 61 | module Response = Cohttp.Response.Make (IO) ^^^^^^^^^^^^^^^^^^^^ Alert deprecated: module Cohttp.Response.Make This functor is not part of the public API. File "curl/ldp_curl.ml", line 75, characters 23-40: 75 | | _ -> Response.has_body res ^^^^^^^^^^^^^^^^^ Error: Unbound value Response.has_body (cd _build/default && /home/opam/.opam/4.14/bin/ocamlc.opt -g -w -40 -w -6-7-9-10-27-32-33-34-35-36-50-52 -no-strict-sequence -g -bin-annot -I curl/.ldp_curl.objs/byte -I /home/opam/.opam/4.14/lib/angstrom -I /home/opam/.opam/4.14/lib/base64 -I /home/opam/.opam/4.14/lib/bigstringaf -I /home/opam/.opam/4.14/lib/bytes -I /home/opam/.opam/4.14/lib/cohttp -I /home/opam/.opam/4.14/lib/cohttp-lwt -I /home/opam/.opam/4.14/lib/curl -I /home/opam/.opam/4.14/lib/dune-build-info -I /home/opam/.opam/4.14/lib/fmt -I /home/opam/.opam/4.14/lib/gen -I /home/opam/.opam/4.14/lib/http -I /home/opam/.opam/4.14/lib/iri -I /home/opam/.opam/4.14/lib/ldp -I /home/opam/.opam/4.14/lib/logs -I /home/opam/.opam/4.14/lib/lwt -I /home/opam/.opam/4.14/lib/lwt/unix -I /home/opam/.opam/4.14/lib/menhirLib -I /home/opam/.opam/4.14/lib/ocaml/threads -I /home/opam/.opam/4.14/lib/ocf -I /home/opam/.opam/4.14/lib/ocplib-endian -I /home/opam/.opam/4.14/lib/ocplib-endian/bigstring -I /home/opam/.opam/4.14/lib/pcre -I /home/opam/.opam/4.14/lib/ppx_sexp_conv/runtime-lib -I /home/opam/.opam/4.14/lib/ptime -I /home/opam/.opam/4.14/lib/rdf -I /home/opam/.opam/4.14/lib/re -I /home/opam/.opam/4.14/lib/re/str -I /home/opam/.opam/4.14/lib/sedlex -I /home/opam/.opam/4.14/lib/seq -I /home/opam/.opam/4.14/lib/sexplib0 -I /home/opam/.opam/4.14/lib/stringext -I /home/opam/.opam/4.14/lib/uri -I /home/opam/.opam/4.14/lib/uri-sexp -I /home/opam/.opam/4.14/lib/uucp -I /home/opam/.opam/4.14/lib/uuidm -I /home/opam/.opam/4.14/lib/uunf -I /home/opam/.opam/4.14/lib/uutf -I /home/opam/.opam/4.14/lib/xmlm -I /home/opam/.opam/4.14/lib/yojson -intf-suffix .ml -no-alias-deps -o curl/.ldp_curl.objs/byte/ldp_curl.cmo -c -impl curl/ldp_curl.pp.ml) File "curl/ldp_curl.ml", line 61, characters 22-42: 61 | module Response = Cohttp.Response.Make (IO) ^^^^^^^^^^^^^^^^^^^^ Alert deprecated: module Cohttp.Response.Make This functor is not part of the public API. File "curl/ldp_curl.ml", line 75, characters 23-40: 75 | | _ -> Response.has_body res ^^^^^^^^^^^^^^^^^ Error: Unbound value Response.has_body ``` Signed-off-by: Marcello Seri <[email protected]>
Fails with ``` === ERROR while compiling tidy_email_sendgrid.0.0.1 ==========================# context 2.4.0~alpha1~dev | linux/x86_64 | ocaml-base-compiler.4.14.2 | file:///home/opam/opam-repository path ~/.opam/4.14/.opam-switch/build/tidy_email_sendgrid.0.0.1 command ~/.opam/opam-init/hooks/sandbox.sh build dune build -p tidy_email_sendgrid -j 39 @install exit-code 1 env-file ~/.opam/log/tidy_email_sendgrid-7-be480f.env output-file ~/.opam/log/tidy_email_sendgrid-7-be480f.out (cd _build/default && /home/opam/.opam/4.14/bin/ocamlc.opt -w -40 -g -bin-annot -I sendgrid/src/.tidy_email_sendgrid.objs/byte -I /home/opam/.opam/4.14/lib/angstrom -I /home/opam/.opam/4.14/lib/astring -I /home/opam/.opam/4.14/lib/base64 -I /home/opam/.opam/4.14/lib/bigstringaf -I /home/opam/.opam/4.14/lib/bytes -I /home/opam/.opam/4.14/lib/cohttp -I /home/opam/.opam/4.14/lib/cohttp-lwt -I /home/opam/.opam/4.14/lib/cohttp-lwt-unix -I /home/opam/.opam/4.14/lib/conduit -I /home/opam/.opam/4.14/lib/conduit-lwt -I /home/opam/.opam/4.14/lib/conduit-lwt-unix -I /home/opam/.opam/4.14/lib/domain-name -I /home/opam/.opam/4.14/lib/fmt -I /home/opam/.opam/4.14/lib/http -I /home/opam/.opam/4.14/lib/ipaddr -I /home/opam/.opam/4.14/lib/ipaddr-sexp -I /home/opam/.opam/4.14/lib/ipaddr/unix -I /home/opam/.opam/4.14/lib/logs -I /home/opam/.opam/4.14/lib/lwt -I /home/opam/.opam/4.14/lib/lwt/unix -I /home/opam/.opam/4.14/lib/macaddr -I /home/opam/.opam/4.14/lib/magic-mime -I /home/opam/.opam/4.14/lib/ocaml/threads -I /home/opam/.opam/4.14/lib/ocplib-endian -I /home/opam/.opam/4.14/lib/ocplib-endian/bigstring -I /home/opam/.opam/4.14/lib/ppx_sexp_conv/runtime-lib -I /home/opam/.opam/4.14/lib/re -I /home/opam/.opam/4.14/lib/seq -I /home/opam/.opam/4.14/lib/sexplib0 -I /home/opam/.opam/4.14/lib/stringext -I /home/opam/.opam/4.14/lib/tidy_email -I /home/opam/.opam/4.14/lib/uri -I /home/opam/.opam/4.14/lib/uri-sexp -I /home/opam/.opam/4.14/lib/uri/services -I /home/opam/.opam/4.14/lib/yojson -intf-suffix .ml -no-alias-deps -o sendgrid/src/.tidy_email_sendgrid.objs/byte/tidy_email_sendgrid.cmo -c -impl sendgrid/src/tidy_email_sendgrid.pp.ml) File "sendgrid/src/tidy_email_sendgrid.ml", line 40, characters 16-47: 40 | ~ctx:Cohttp_lwt_unix.Net.default_ctx ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ Error: This expression has type Cohttp_lwt_unix.Net.ctx Lazy.t = Cohttp_lwt_unix.Net.ctx lazy_t but an expression was expected of type Cohttp_lwt_unix.Client.ctx = Cohttp_lwt_unix.Net.ctx (cd _build/default && /home/opam/.opam/4.14/bin/ocamlopt.opt -w -40 -g -I sendgrid/src/.tidy_email_sendgrid.objs/byte -I sendgrid/src/.tidy_email_sendgrid.objs/native -I /home/opam/.opam/4.14/lib/angstrom -I /home/opam/.opam/4.14/lib/astring -I /home/opam/.opam/4.14/lib/base64 -I /home/opam/.opam/4.14/lib/bigstringaf -I /home/opam/.opam/4.14/lib/bytes -I /home/opam/.opam/4.14/lib/cohttp -I /home/opam/.opam/4.14/lib/cohttp-lwt -I /home/opam/.opam/4.14/lib/cohttp-lwt-unix -I /home/opam/.opam/4.14/lib/conduit -I /home/opam/.opam/4.14/lib/conduit-lwt -I /home/opam/.opam/4.14/lib/conduit-lwt-unix -I /home/opam/.opam/4.14/lib/domain-name -I /home/opam/.opam/4.14/lib/fmt -I /home/opam/.opam/4.14/lib/http -I /home/opam/.opam/4.14/lib/http/__private__/http_bytebuffer -I /home/opam/.opam/4.14/lib/ipaddr -I /home/opam/.opam/4.14/lib/ipaddr-sexp -I /home/opam/.opam/4.14/lib/ipaddr/unix -I /home/opam/.opam/4.14/lib/logs -I /home/opam/.opam/4.14/lib/lwt -I /home/opam/.opam/4.14/lib/lwt/unix -I /home/opam/.opam/4.14/lib/macaddr -I /home/opam/.opam/4.14/lib/magic-mime -I /home/opam/.opam/4.14/lib/ocaml/threads -I /home/opam/.opam/4.14/lib/ocplib-endian -I /home/opam/.opam/4.14/lib/ocplib-endian/bigstring -I /home/opam/.opam/4.14/lib/ppx_sexp_conv/runtime-lib -I /home/opam/.opam/4.14/lib/re -I /home/opam/.opam/4.14/lib/seq -I /home/opam/.opam/4.14/lib/sexplib0 -I /home/opam/.opam/4.14/lib/stringext -I /home/opam/.opam/4.14/lib/tidy_email -I /home/opam/.opam/4.14/lib/uri -I /home/opam/.opam/4.14/lib/uri-sexp -I /home/opam/.opam/4.14/lib/uri/services -I /home/opam/.opam/4.14/lib/yojson -intf-suffix .ml -no-alias-deps -o sendgrid/src/.tidy_email_sendgrid.objs/native/tidy_email_sendgrid.cmx -c -impl sendgrid/src/tidy_email_sendgrid.pp.ml) File "sendgrid/src/tidy_email_sendgrid.ml", line 40, characters 16-47: 40 | ~ctx:Cohttp_lwt_unix.Net.default_ctx ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ Error: This expression has type Cohttp_lwt_unix.Net.ctx Lazy.t = Cohttp_lwt_unix.Net.ctx lazy_t but an expression was expected of type Cohttp_lwt_unix.Client.ctx = Cohttp_lwt_unix.Net.ctx ``` Signed-off-by: Marcello Seri <[email protected]>
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Seen on #26925
Failures in commit messages