Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The post step should not fail if there is an error #891

Merged
merged 1 commit into from
Nov 9, 2024
Merged

The post step should not fail if there is an error #891

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion analysis/dist/index.js
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 3 additions & 3 deletions dist/index.js
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

7 changes: 4 additions & 3 deletions dist/post/index.js
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion lint-doc/dist/index.js
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion lint-fmt/dist/index.js
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion lint-opam/dist/index.js
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion packages/analysis/src/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ async function run() {
process.exit(0);
} catch (error) {
if (error instanceof Error) {
core.setFailed(error.message);
core.error(error.message);
}
process.exit(1);
}
Expand Down
2 changes: 1 addition & 1 deletion packages/lint-doc/src/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ async function run() {
process.exit(0);
} catch (error) {
if (error instanceof Error) {
core.setFailed(error.message);
core.error(error.message);
}
process.exit(1);
}
Expand Down
2 changes: 1 addition & 1 deletion packages/lint-fmt/src/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ async function run() {
process.exit(0);
} catch (error) {
if (error instanceof Error) {
core.setFailed(error.message);
core.error(error.message);
}
process.exit(1);
}
Expand Down
2 changes: 1 addition & 1 deletion packages/lint-opam/src/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ async function run() {
process.exit(0);
} catch (error) {
if (error instanceof Error) {
core.setFailed(error.message);
core.error(error.message);
}
process.exit(1);
}
Expand Down
4 changes: 2 additions & 2 deletions packages/setup-ocaml/src/cache.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -127,7 +127,7 @@ async function restoreCache(
if (error instanceof Error) {
core.info(error.message);
}
core.warning(
core.notice(
"An internal error has occurred in cache backend. Please check https://www.githubstatus.com for any ongoing issue in actions.",
);
return;
Expand All @@ -145,7 +145,7 @@ async function saveCache(key: string, paths: string[]) {
if (error instanceof Error) {
core.info(error.message);
}
core.warning(
core.notice(
"An internal error has occurred in cache backend. Please check https://www.githubstatus.com for any ongoing issue in actions.",
);
}
Expand Down
2 changes: 1 addition & 1 deletion packages/setup-ocaml/src/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ async function run() {
process.exit(0);
} catch (error) {
if (error instanceof Error) {
core.setFailed(error.message);
core.error(error.message);
}
process.exit(1);
}
Expand Down
3 changes: 2 additions & 1 deletion packages/setup-ocaml/src/post.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,8 @@ async function run() {
if (error instanceof Error) {
core.error(error.message);
}
process.exit(1);
// The post step should not fail if there is an error...
process.exit(0);
}
}

Expand Down