-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Translated the hh
-lambda loop
#32
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See bb7b6e4 for details.
`[]` is technically possible, but has no bounds check. See <https://arma.sourceforge.net/docs.html#element_access> for more details.
This should streamline processing through `hh_nlambda_loop_cpp()`.
The only missing part now are bits related to and dependend on the translation of `count_nonzero_a()`.
Still needs to translate `count_nonzero_a()`, which is currently bring pulled from R with a performance penalty. However, this version is already useful for comparing outputs of `legacy = TRUE` and `legacy = FALSE`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Lots of changes related to work towards #17.
Most relevant commits
hh <= nlamba
loop as R functionhh_nlambda_loop()
(Slowadmm_MADMMplasso()
underADMMplasso()
#17)hh_nlambda_loop()
to C++ ashh_nlambda_loop_cpp()
(Slowadmm_MADMMplasso()
underADMMplasso()
#17)count_nonzero_a()
to C++ (Slowadmm_MADMMplasso()
underADMMplasso()
#17)print(cost_time)
only triggers ifmy_print == TRUE
There are a couple of issues detected during this work, but they'll be left to another issue since they are already present on main (meaning they were not introduced here). Namely:
MADMMplasso/tests/testthat/test-MADMMplasso.R
Lines 83 to 102 in 2b4d267