Use cl to calculate parallel
#48
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Dear Waldir, Best regards, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since
clonly makes sense ifparallel = TRUE, it can be used to calculate the latter. This results in less function complexity (one fewer argument for the user to have to set), but I wonder if it makes the function any more intuitive.If the user sets
par = TRUE,clis automatically set to 1. Otherwise, it defaults todetectCores() - 1L(instead of the previous4, which causes issues on simpler systems such as remote runners).Looking forward to your thoughts on this, Theo!
Merging this should close #40.