feat(database): supports query database by tenantName、clusterNam and dataSourceName #4232
Conversation
ysjemmm
requested review from
LioRoger,
guowl3 and
MarkPotato777
as code owners
...e/src/main/java/com/oceanbase/odc/service/connection/database/model/QueryDatabaseParams.java
Outdated
Show resolved
Hide resolved
...odc-service/src/main/java/com/oceanbase/odc/service/connection/database/DatabaseService.java
Outdated
Show resolved
Hide resolved
...odc-service/src/main/java/com/oceanbase/odc/service/connection/database/DatabaseService.java
Outdated
Show resolved
Hide resolved
...odc-service/src/main/java/com/oceanbase/odc/service/connection/database/DatabaseService.java
Outdated
Show resolved
Hide resolved
server/odc-service/src/main/java/com/oceanbase/odc/metadb/connection/DatabaseSpecs.java
Show resolved
Hide resolved
...odc-service/src/main/java/com/oceanbase/odc/service/connection/database/DatabaseService.java
Outdated
Show resolved
Hide resolved
.../odc-server/src/main/java/com/oceanbase/odc/server/web/controller/v2/DataBaseController.java
Outdated
Show resolved
Hide resolved
server/odc-service/src/main/java/com/oceanbase/odc/service/connection/ConnectionService.java
Outdated
Show resolved
Hide resolved
server/odc-service/src/main/java/com/oceanbase/odc/service/connection/ConnectionService.java
Show resolved
Hide resolved
ysjemmm
requested review from
Jane201510,
JessieWuJiexi,
LuckyPickleZZ,
zijiacj,
PeachThinking,
CHLK and
kiko-art
as code owners
ysjemmm
force-pushed
the
mayang_434_database_query_optimization
branch
from
be7421c to
91e7e5b
Compare
ysjemmm
removed request for
Jane201510,
CHLK,
LuckyPickleZZ,
kiko-art,
JessieWuJiexi,
zijiacj and
PeachThinking
server/odc-service/src/main/java/com/oceanbase/odc/service/connection/ConnectionService.java
Show resolved
Hide resolved
| String clusterName) { | ||
| long conditionCount = Stream.of(dataSourceName, tenantName, clusterName).filter(StringUtils::isNotBlank) | ||
| .count(); | ||
| if (conditionCount == 0L || conditionCount >= 2L) { |
There was a problem hiding this comment.
Why return empty set when conditionCount >= 2?
It's tricky to use magic numbers 0L and 2L.
There was a problem hiding this comment.
I only need one condition at most, otherwise it doesn't fit the function
There was a problem hiding this comment.
Then just verify the conditionCount == 1, and throw an exception if not.
There was a problem hiding this comment.
BTW, this method is not readable. The caller is not aware that you only accept one of the parameters. Think about what you will do when you are required to accept more parameters in future features.
There was a problem hiding this comment.
BTW, this method is not readable. The caller is not aware that you only accept one of the parameters. Think about what you will do when you are required to accept more parameters in future features.
If there are multiple conditions, all I can think of is using Map, or using Function, leaving the decision to the caller
What type of PR is this?
type-feature
What this PR does / why we need it:
Databases can be queried by tenantName, clusterName and dataSourceName