podspec: Add React dependency #90
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Depending on which modules are built and in which order, `React/RCTBridgeModule.h` may or may not be available. Some workarounds for this include disabling parallel builds (https://stackoverflow.com/a/43340802), manually linking against the library instead of using cocoapods (ocetnik#87 (comment)), changing the way source files are imported (https://stackoverflow.com/a/41664041), and some others. These workarounds appear to fundamentally disregard the actual problem, which is that these React Native packages all depend on React, and need to be built after the React package has been built. So let's describe this dependency so the build system can solve the issue for us consistently. Another example of this same issue/fix with another React Native package can be found [here](charlires/react-native-segment-analytics#33). Fixes ocetnik#87.
|
Note that on further inspection, I've realized this was removed in bdcf498. I'm not sure this was the correct solution for #71, but admittedly I'm not sure what the proper fix should be. It would seem I'm not the only one who's discovered this problem after that patch was merged, though (see #82 as well). |
|
Thank you so much @yupferris 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depending on which modules are built and in which order,
React/RCTBridgeModule.hmay or may not be available. Some workarounds for this include disabling parallel builds (https://stackoverflow.com/a/43340802), manually linking against the library instead of using cocoapods (#87 (comment)), changing the way source files are imported (https://stackoverflow.com/a/41664041), and some others. These workarounds appear to fundamentally disregard the actual problem, which is that these React Native packages all depend on React, and need to be built after the React package has been built. So let's describe this dependency so the build system can solve the issue for us consistently.Another example of this same issue/fix with another React Native package can be found here.
Fixes #87.