Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added monitoring_config.py #92

Conversation

alokgoswami-ag
Copy link
Contributor

fixes #91
Added constant file and moved all constant in constant.py.

@KeerthanaAP
Copy link
Collaborator

@alokgoswami-ag Could you add this constant as well
https://github.com/ocp-power-automation/ci-monitoring-automation/blob/main/monitor.py#L14
But I would suggest a different file name instead of constants.py

@KeerthanaAP
Copy link
Collaborator

@Shilpa-Gokul Could you ptal

monitor.py Outdated Show resolved Hide resolved
monitor.py Outdated Show resolved Hide resolved
monitor.py Outdated Show resolved Hide resolved
monitor.py Outdated Show resolved Hide resolved
monitoring_config.py Outdated Show resolved Hide resolved
Signed-off-by: alokgoswami-ag <[email protected]>
@KeerthanaAP
Copy link
Collaborator

/lgtm

Copy link
Collaborator

@Shilpa-Gokul Shilpa-Gokul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@ppc64le-cloud-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alokgoswami-ag, Shilpa-Gokul

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ppc64le-cloud-bot ppc64le-cloud-bot merged commit b77856e into ocp-power-automation:main Jan 6, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move all the constants to a seperate file
4 participants