-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OCTOPUS-625:Added role for approve and issue csr cert and get vm file #21
Conversation
|
||
# Re-read the 'Ready' count | ||
READY_COUNT=$(oc get nodes -l kubernetes.io/arch=amd64 | grep "${MACHINE_PREFIX}" | grep -v NotReady | grep -c Ready) | ||
done |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @pkenchap @Chandan-Abhyankar refactored this script recently at https://github.com/IBM/ocp4-upi-compute-powervs/blob/main/ansible/post/files/approve_and_issue.sh. it'd be worth pulling that in here. and removing the reference to the proxy.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@prb112 , Used the same script and modified with removing the proxy .
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
a couple of suggestions are left inline
7122d58
to
9e17b54
Compare
openstack/intel-worker/playbooks/roles/approve_and_issue/files/approve_and_issue.sh
Show resolved
Hide resolved
Signed-off-by: Punith Kenchappa <[email protected]>
Hi Paul, Looping I updated the script and it works seemlessly for the approve and issue .
` I had made the looping in the playbook will go in iteration of creating the VM's as per the user requirement of worker nodes. |
Added the role for approve and issue csr certificate .
Also added get vm file with wait until VM comes to active state.