OPENSHIFTP-122: Refactor the get_vm file and image id #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
pkenchap
commented
Jun 13, 2024
•
pkenchap
commented
- Added minor changes to the get_vm file instead of having the different function.
- Image id been replaced with rhcos image instead of centos .
- Modified the playbook name and segregated with different files instead of having in same file which makes user confusion.
Signed-off-by: Punith Kenchappa <[email protected]>
prb112
reviewed
Jun 13, 2024
| @@ -3,12 +3,12 @@ | |||
| vm_create_name: rdr-mac-worker-openstack | |||
| vm_create_region_name: RegionOne | |||
| vm_create_availability_zone: Test | |||
| vm_create_image_name: 4df699b6-6877-4b77-9ddb-0d6dc9cefb68 | |||
| vm_create_image_name: d424a441-6b4c-4e22-adb7-69935b398579 | |||
prb112
approved these changes
Jun 13, 2024
Signed-off-by: Punith Kenchappa <[email protected]>
prb112
approved these changes
Jun 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.