Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

complement of readme file #300

Closed
wants to merge 2 commits into from
Closed

complement of readme file #300

wants to merge 2 commits into from

Conversation

xS-Sx
Copy link

@xS-Sx xS-Sx commented Mar 16, 2018

No description provided.

Copy link
Collaborator

@zuphilip zuphilip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Too complicated, but maybe git clone is worth to mention. @kba Any thoughts?

Maybe, we can also enumerate these steps, i.e. along
1.) git clone
2.a) system-wide installation
2.b) virtual env
2.c) conda
3.) test

Would that help?

$ mkdir workingcopy/
$ cd workingcopy/
$ git init .
$ git pull https://github.com/tmbdev/ocropy
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That seems too complicated and git clone should be enough for everything here.

@kba
Copy link
Collaborator

kba commented Jan 14, 2019

Since this is GitHub, git clone is implied for all the install-from-source-steps IMHO.

But if #319 lands, we should consider adding steps to install with pip. In @OCR-D we've been publishing a fork to pypi, so you can do

pip install ocrd-fork-ocropy

without cloning and in fact use ocropy as a dependency in other projects.

@zuphilip
Copy link
Collaborator

Yes, the pip looks really simple. But will this also download the models? Is it clear where I have to save the new models if I have installed ocropy with pip locally or globally? (Maybe, we have to add more documentation then or can even provide some sort of helper script for such cases...)

@kba
Copy link
Collaborator

kba commented Jan 14, 2019

Users do have to save models to one of the places ocropy searches for them. They can do that manually (wget), use https://github.com/kba/ocr-models-client or we could bundle a script like kraken does.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants