Modern C and compatibility fixes #1022
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BSD mincore last parameter is a char *. Linux mincore last parameter is an unsigned char *. The test had it reversed. https://man.freebsd.org/cgi/man.cgi?query=mincore https://docs.oracle.com/cd/E88353_01/html/E37841/mincore-2.html https://linux.die.net/man/2/mincore
This allows configuring caml headers first, and then overwriting declarations (for compatibility).
smorimoto
approved these changes
Jul 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
(void)(no parameter) instead of()(pre C89 any parameter);mincoredetection on BSD and macOS;caml_convert_flag_listtaking anint *in OCaml 4 and aconst int *in OCaml 5, with a minor header reordering;