-
Notifications
You must be signed in to change notification settings - Fork 176
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable to read which backend was picked by libev. #985
Conversation
I'm at a loss as to why this fails in ocaml-ci with |
This seems like a reasonable addition. I'll look into the failure. |
I started the other CI tests (I just noticed they needed an approval start) and they paint a much clearer picture: the error occurs when the code is compiled with libev deactivated. I've pushed a commit adding some |
It doesn't work, same error. I'll dig further. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi, we're still interested in having this upstream.
I don't know how to reproduce the CI failure, but I made a suggestion for the fix in the code: Use the LWT_NOT_AVAILABLE1
macro when libev is not available, similarly to the other functions in the module.
The remaining CI issues seem to be the same as master AFAICS. |
This reverts commit 8d179bf.
Thanks! |
Thanks a lot for the contribution <3 |
My use case for this is letting libev choose its backend freely, but checking it did not fallback to
select
in production as the 1024 file descriptor limit is not fit for purpose.