Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add filesystem.localToPublic event #628

Merged
merged 1 commit into from
May 13, 2024
Merged

Conversation

acasar
Copy link
Contributor

@acasar acasar commented May 6, 2024

Would you consider adding this event to the core? We have a special case where we are using symlinks to include core OctoberCMS files into the project to isolate each project under its own cPanel account while still beeing able to update all projects with a single deploy. Currently such a special situation is sometimes not handeled correctly by the localToPublic helper (null is returned).

image

By adding this event we could allow developers to implement custom logic for converting local to public paths and solve special cases such as this.

@daftspunk daftspunk merged commit 52e67e1 into octobercms:3.x May 13, 2024
4 checks passed
@daftspunk
Copy link
Member

Looks great, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants