Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Upgrade .NET from Core 3.1 to 8.0 (and Native AOT!) #321

Draft
wants to merge 34 commits into
base: main
Choose a base branch
from
Draft

Feature: Upgrade .NET from Core 3.1 to 8.0 (and Native AOT!) #321

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
34 commits
Select commit Hold shift + click to select a range
1c84944
⬆️ Upgrade `.NET` from Core 3.1 to 8.0
Lamparter Sep 6, 2024
6456733
⬆️ Upgrade API projects to .NET 8
Lamparter Sep 7, 2024
6fc0afc
⚡️ Add .NET Native AOT
Lamparter Sep 7, 2024
6fb9559
✏️ Fix typo in unit tests
Lamparter Sep 8, 2024
e445b1c
🐛 Fix `Run_Specifies_Cancellation_Token` error
Lamparter Sep 8, 2024
253a5b0
🎨 Remove trailing space
Lamparter Sep 8, 2024
7607fa1
🔀 Merge branch `main` into `dotnet`
Lamparter Sep 28, 2024
38577dd
🔀 Merge branch `main` into `dotnet`
Lamparter Sep 28, 2024
1d58ce2
Update Octokit.GraphQL.Core.Generation.UnitTests.csproj
0x5bfa Sep 28, 2024
ac288db
💚 Fix solution configuration
Lamparter Sep 28, 2024
bbb68bf
Update Octokit.GraphQL.Core.Generation.csproj
0x5bfa Sep 28, 2024
bd9eea7
Update Octokit.GraphQL.Core.UnitTests.csproj
0x5bfa Sep 28, 2024
78ea5bf
Update Octokit.GraphQL.Core.csproj
0x5bfa Sep 28, 2024
cf89ad9
Update Octokit.GraphQL.IntegrationTests.csproj
0x5bfa Sep 28, 2024
c4dbc6c
Update Octokit.GraphQL.UnitTests.csproj
0x5bfa Sep 28, 2024
cb2cb6a
Update Octokit.GraphQL.csproj
0x5bfa Sep 28, 2024
93a3339
Update Generate.csproj
0x5bfa Sep 28, 2024
1554f52
Update Octokit.GraphQL.Pack.csproj
0x5bfa Sep 28, 2024
183ff1e
Merge branch 'octokit:main' into dotnet
0x5bfa Nov 8, 2024
2dd9202
Update ci.yml
0x5bfa Nov 8, 2024
b794dc9
Update Octokit.GraphQL.Pack.csproj
0x5bfa Nov 8, 2024
96237f2
Update Octokit.GraphQL.Pack.csproj
0x5bfa Nov 8, 2024
5116889
Update Octokit.GraphQL.nuspec
0x5bfa Nov 8, 2024
5cbb2b7
Update Octokit.GraphQL.Pack.csproj
0x5bfa Nov 8, 2024
bf5a0aa
Update Octokit.GraphQL.nuspec
0x5bfa Nov 8, 2024
808621b
Update Octokit.GraphQL.Core.csproj
0x5bfa Nov 8, 2024
869fbba
Update Octokit.GraphQL.csproj
0x5bfa Nov 8, 2024
d97f6ef
Update Octokit.GraphQL.csproj
0x5bfa Nov 8, 2024
26a5625
Update readme.md
0x5bfa Nov 8, 2024
88384a7
Delete scripts directory
0x5bfa Nov 8, 2024
6addd58
Delete lib directory
0x5bfa Nov 8, 2024
f9b5de6
Add files via upload
0x5bfa Nov 8, 2024
051751f
Rename src/Octokit.GraphQL.Core.UnitTests/AgileObjects.ReadableExpres…
0x5bfa Nov 8, 2024
66f85ad
Update nuget.config
0x5bfa Nov 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 1 addition & 5 deletions Octokit.GraphQL.Core.Generation.UnitTests/Octokit.GraphQL.Core.Generation.UnitTests.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
<Project Sdk="Microsoft.NET.Sdk">
<PropertyGroup>
<TargetFramework>netcoreapp3.1</TargetFramework>
<LangVersion>7.2</LangVersion>
<TargetFramework>net8.0</TargetFramework>
</PropertyGroup>
<ItemGroup>
<PackageReference Include="coverlet.msbuild" Version="2.8.1">
Expand All @@ -18,7 +17,4 @@
<ItemGroup>
<ProjectReference Include="..\Octokit.GraphQL.Core.Generation\Octokit.GraphQL.Core.Generation.csproj" />
</ItemGroup>
<ItemGroup>
<Service Include="{82a7f48d-3b50-4b1e-b82e-3ada8210c358}" />
</ItemGroup>
</Project>
6 changes: 5 additions & 1 deletion Octokit.GraphQL.Core.Generation/Octokit.GraphQL.Core.Generation.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,12 @@
<Project Sdk="Microsoft.NET.Sdk">
<PropertyGroup>
<TargetFramework>netstandard2.0</TargetFramework>
<TargetFramework>net8.0</TargetFramework>
<LangVersion>7.2</LangVersion>
</PropertyGroup>
<PropertyGroup>
<IsAotCompatible Condition="$([MSBuild]::IsTargetFrameworkCompatible('$(TargetFramework)', 'net7.0'))">true</IsAotCompatible>
<PublishAot>true</PublishAot>
Lamparter marked this conversation as resolved.
Show resolved Hide resolved
</PropertyGroup>
<ItemGroup>
<ProjectReference Include="..\Octokit.GraphQL.Core\Octokit.GraphQL.Core.csproj" />
</ItemGroup>
Expand Down
3 changes: 1 addition & 2 deletions Octokit.GraphQL.Core.UnitTests/Octokit.GraphQL.Core.UnitTests.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
<Project Sdk="Microsoft.NET.Sdk">
<PropertyGroup>
<TargetFramework>netcoreapp3.1</TargetFramework>
<LangVersion>7.2</LangVersion>
<TargetFramework>net8.0</TargetFramework>
</PropertyGroup>
<ItemGroup>
<PackageReference Include="AgileObjects.ReadableExpressions" Version="1.12.1" />
Expand Down
7 changes: 5 additions & 2 deletions Octokit.GraphQL.Core/Octokit.GraphQL.Core.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,13 +1,16 @@
<Project Sdk="Microsoft.NET.Sdk">
<PropertyGroup>
<TargetFramework>netstandard2.0</TargetFramework>
<TargetFramework>net8.0</TargetFramework>
<RootNamespace>Octokit.GraphQL</RootNamespace>
<SignAssembly>true</SignAssembly>
<AssemblyOriginatorKeyFile>..\key.snk</AssemblyOriginatorKeyFile>
<PublicSign Condition=" '$(OS)' != 'Windows_NT' ">true</PublicSign>
<DocumentationFile>bin\$(Configuration)\netstandard1.1\Octokit.GraphQL.Core.xml</DocumentationFile>
<LangVersion>7.2</LangVersion>
</PropertyGroup>
<PropertyGroup>
<IsAotCompatible Condition="$([MSBuild]::IsTargetFrameworkCompatible('$(TargetFramework)', 'net7.0'))">true</IsAotCompatible>
<PublishAot>true</PublishAot>
</PropertyGroup>
<ItemGroup>
<PackageReference Include="Newtonsoft.Json" Version="13.0.2" />
<PackageReference Include="System.ValueTuple" Version="4.4.0" />
Expand Down
3 changes: 1 addition & 2 deletions Octokit.GraphQL.IntegrationTests/Octokit.GraphQL.IntegrationTests.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,7 @@
<Project Sdk="Microsoft.NET.Sdk">
<PropertyGroup>
<TargetFramework>netcoreapp3.1</TargetFramework>
<TargetFramework>net8.0</TargetFramework>
<AssemblyName>Octokit.GraphQL.IntegrationTests</AssemblyName>
<LangVersion>7.2</LangVersion>
</PropertyGroup>
<ItemGroup>
<PackageReference Include="Microsoft.NET.Test.Sdk" Version="16.5.0" />
Expand Down
9 changes: 1 addition & 8 deletions Octokit.GraphQL.UnitTests/Octokit.GraphQL.UnitTests.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
<Project Sdk="Microsoft.NET.Sdk">
<PropertyGroup>
<TargetFramework>netcoreapp3.1</TargetFramework>
<LangVersion>7.2</LangVersion>
<TargetFramework>net8.0</TargetFramework>
</PropertyGroup>
<ItemGroup>
<PackageReference Include="Codecov" Version="1.10.0" />
Expand All @@ -20,10 +19,4 @@
<ProjectReference Include="..\Octokit.GraphQL.Core.UnitTests\Octokit.GraphQL.Core.UnitTests.csproj" />
<ProjectReference Include="..\Octokit.GraphQL\Octokit.GraphQL.csproj" />
</ItemGroup>
<ItemGroup>
<Folder Include="Properties\" />
</ItemGroup>
<ItemGroup>
<Service Include="{82a7f48d-3b50-4b1e-b82e-3ada8210c358}" />
</ItemGroup>
</Project>
10 changes: 5 additions & 5 deletions Octokit.GraphQL/Octokit.GraphQL.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,16 +1,16 @@
<Project Sdk="Microsoft.NET.Sdk">
<PropertyGroup>
<TargetFramework>netstandard2.0</TargetFramework>
<TargetFramework>net8.0</TargetFramework>
<SignAssembly>true</SignAssembly>
<AssemblyOriginatorKeyFile>..\key.snk</AssemblyOriginatorKeyFile>
<PublicSign Condition=" '$(OS)' != 'Windows_NT' ">true</PublicSign>
<DocumentationFile>bin\$(Configuration)\netstandard1.1\Octokit.GraphQL.xml</DocumentationFile>
<LangVersion>7.2</LangVersion>
</PropertyGroup>
<PropertyGroup>
<IsAotCompatible Condition="$([MSBuild]::IsTargetFrameworkCompatible('$(TargetFramework)', 'net7.0'))">true</IsAotCompatible>
<PublishAot>true</PublishAot>
</PropertyGroup>
<ItemGroup>
<ProjectReference Include="..\Octokit.GraphQL.Core\Octokit.GraphQL.Core.csproj" />
</ItemGroup>
<ItemGroup>
<Folder Include="Properties\" />
</ItemGroup>
</Project>
3 changes: 1 addition & 2 deletions Tools/Generate/Generate.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,7 @@
<Project Sdk="Microsoft.NET.Sdk">
<PropertyGroup>
<OutputType>Exe</OutputType>
<TargetFramework>netcoreapp3.1</TargetFramework>
<LangVersion>7.2</LangVersion>
<TargetFramework>net8.0</TargetFramework>
</PropertyGroup>
<ItemGroup>
<ProjectReference Include="..\..\Octokit.GraphQL.Core.Generation\Octokit.GraphQL.Core.Generation.csproj" />
Expand Down