Update for cohttp 6 Response API #398
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cohttp 6 introduced a breaking change to the `Response` API dropping `flush` in mirage/ocaml-cohttp#1052 This updates our usage to be compatible.
shonfeder
force-pushed
the
update-for-cohttp-6
branch
from
187d957 to
6f874c2
Compare
punchagan
approved these changes
Nov 29, 2024
|
Thank you for he review :) Look at the changelog I see no other obvious cause for concern. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cohttp 6 introduced a breaking change to the
ResponseAPI droppingflushin mirage/ocaml-cohttp#1052This updates our usage to be compatible.