Add implementation warning for browsers #145
Conversation
✅ Deploy Preview for oddcontrast ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
It isn't specific to Oklab (and Oklch) though, is it? You would get the same with CIE Lab and LCH, or
seems more accurate. I'm concerned that people internalize "Oklab has problems" instead of "browsers unwisely prioritized speed over color consistency, so users have to do extra work". |
@svgeesus Good point, and my description glossed over that the message updates to match whatever space is selected. But your point still stands that it isn't something about Currently it is only shown for unbounded spaces, but you bring up a fair point about the same issue for values that are out of bounds in However, our tool doesn't easily allow the creation of out of bounds values in My proposal-
|
There was a problem hiding this comment.
Not clear to me if this is waiting for style cleanup? We should either fix the error layout issues here, or make sure that's captured in another issue.
It seems like we show the implementation warning any time you're in a (ok)lab/lch format. Maybe we can only show the warning when you're outside the srgb gamut? (I'm not sure if there's a way for us to query the actual display gamut?)
|
In grooming today, we decided to remove the banner from the top, and instead add more context to the known color issues panel. |
|
This is now moved to the Known Issues section. The known issue in #146 speaks to browser implementation with clipping. This known issue talks about how the new features now allow creation of out of gamut colors, common ways to make those colors, and why to avoid it. |
Co-authored-by: david herron <[email protected]>
* color-issues: sveltekit does not support vite v5 yet pin back stylelint for now Automated dependency upgrades Automated dependency upgrades Bump @adobe/css-tools from 4.3.1 to 4.3.2
* color-issues: adjust grid spacing strong to bold alpha order adjust grid for color issues relocate some styles to lists.scss make link styles consistent put description text in paragraph start cleaning up color issues component styles
Description
Fixes #95.
I ended up with the text "Browser rendering of Oklab for colors outside of the display gamut is incorrect according to the CSS specification."
The link is to Miriam's CSS WG issue.
Steps to test/reproduce
Change between formats, and see that the warning shows for all unbounded formats.