Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Color browser support warning breaks layout [warning-layout] #157

Merged
merged 1 commit into from
Dec 21, 2023

Conversation

stacyk
Copy link
Member

@stacyk stacyk commented Dec 21, 2023

Description

Fixes Issue #152

Steps to test/reproduce

Locally, remove the ! from line 23 in src/lib/components/colors/SupportWarning.svelte
This {#if !isSupported} becomes {#if isSupported}

or use an older browser like old Opera 84

Show me

Screenshot 2023-12-21 at 10 55 00 AM

Copy link

netlify bot commented Dec 21, 2023

Deploy Preview for oddcontrast ready!

Name Link
🔨 Latest commit faa5f73
🔍 Latest deploy log https://app.netlify.com/sites/oddcontrast/deploys/658476af2cd6e3000858c200
😎 Deploy Preview https://deploy-preview-157--oddcontrast.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@stacyk stacyk requested a review from jamesnw December 21, 2023 17:32
@stacyk stacyk linked an issue Dec 21, 2023 that may be closed by this pull request
Copy link
Contributor

@jamesnw jamesnw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@jamesnw jamesnw merged commit 80d51b8 into main Dec 21, 2023
7 checks passed
@jamesnw jamesnw deleted the warning-layout branch December 21, 2023 18:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Color browser support warning breaks layout.
2 participants