Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Svelte 5 #206

Merged
merged 11 commits into from
Nov 8, 2024
Merged

Svelte 5 #206

merged 11 commits into from
Nov 8, 2024

Conversation

jamesnw
Copy link
Contributor

@jamesnw jamesnw commented Oct 23, 2024

Description

Updates to Svelte 5

  • Figure out the multiple form issue
  • Optional: Update store to use runes? (won't do)

Copy link

netlify bot commented Oct 23, 2024

Deploy Preview for oddcontrast ready!

Name Link
🔨 Latest commit 77d1cf4
🔍 Latest deploy log https://app.netlify.com/sites/oddcontrast/deploys/672d351d79cd930008559b68
😎 Deploy Preview https://deploy-preview-206--oddcontrast.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@@ -2,6 +2,10 @@ import { fireEvent, render, waitFor } from '@testing-library/svelte';

import CopyButton from '$lib/components/util/CopyButton.svelte';

function getFirstNonCommentChild(node: Node) {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Svelte now uses comments for hydration, so the first children were comments, which broke the tests. https://svelte.dev/docs/svelte/v5-migration-guide

@jgerigmeyer jgerigmeyer self-requested a review October 25, 2024 18:15
.github/workflows/test.yml Outdated Show resolved Hide resolved
@jamesnw
Copy link
Contributor Author

jamesnw commented Nov 1, 2024

@jgerigmeyer This is ready for a review whenever.

src/lib/components/SpaceSelect.svelte Show resolved Hide resolved
src/lib/components/colors/index.svelte Outdated Show resolved Hide resolved
src/lib/icons/Check.svelte Show resolved Hide resolved
src/lib/icons/Check.svelte Show resolved Hide resolved
src/lib/components/colors/index.svelte Outdated Show resolved Hide resolved
@jgerigmeyer
Copy link
Member

  • Update store to use runes?

I don't feel strongly about this one way or the other. At a glance it looks to me like stores are still less verbose than runes for our purposes, but I'm fine if you want to try converting them.

@jamesnw
Copy link
Contributor Author

jamesnw commented Nov 8, 2024

  • Update store to use runes?

I don't feel strongly about this one way or the other. At a glance it looks to me like stores are still less verbose than runes for our purposes, but I'm fine if you want to try converting them.

Yeah, I don't think it's necessary or helpful at this point.

@jgerigmeyer jgerigmeyer merged commit f3d871a into main Nov 8, 2024
7 checks passed
@jgerigmeyer jgerigmeyer deleted the svelte-5 branch November 8, 2024 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants