-
-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Svelte 5 #206
Svelte 5 #206
Conversation
✅ Deploy Preview for oddcontrast ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
@@ -2,6 +2,10 @@ import { fireEvent, render, waitFor } from '@testing-library/svelte'; | |||
|
|||
import CopyButton from '$lib/components/util/CopyButton.svelte'; | |||
|
|||
function getFirstNonCommentChild(node: Node) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Svelte now uses comments for hydration, so the first children were comments, which broke the tests. https://svelte.dev/docs/svelte/v5-migration-guide
@jgerigmeyer This is ready for a review whenever. |
* main: Show error if not a hex length Handle hashless hex
I don't feel strongly about this one way or the other. At a glance it looks to me like stores are still less verbose than runes for our purposes, but I'm fine if you want to try converting them. |
Yeah, I don't think it's necessary or helpful at this point. |
Description
Updates to Svelte 5