Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change Sass configuaration #205

Merged
merged 32 commits into from
Aug 12, 2022
Merged

change Sass configuaration #205

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
32 commits
Select commit Hold shift + click to select a range
73817c1
use tools for most config files
dvdherron Apr 14, 2022
51d5470
use forwarded accoutrement in components
dvdherron Apr 14, 2022
280d089
use forwarded accoutrement in forms files
dvdherron Apr 14, 2022
6f2115c
reconfigure initial/
dvdherron Apr 14, 2022
f39edf4
reconfigure layout files
dvdherron Apr 14, 2022
5b865f8
reconfigure page and patterns
dvdherron Apr 15, 2022
8d43188
wip: separate colors into modules
dvdherron Apr 19, 2022
9ff50f2
hide ccs color previews
dvdherron Apr 21, 2022
0fb728c
move ccs defaults
dvdherron Apr 21, 2022
0fed177
Merge branch 'main' into sass-config
dvdherron May 17, 2022
2020b47
Merge branch 'main' into sass-config
dvdherron Jun 14, 2022
2339047
move color config
dvdherron Jun 15, 2022
a022eab
@use 'sass:map' and map.get() in color config
stacyk Aug 1, 2022
9e1d20d
convert sass color maps to variables
stacyk Aug 1, 2022
e8c9d58
remove unused
stacyk Aug 1, 2022
86117cb
simplify color include, lint
stacyk Aug 1, 2022
aac7f3f
show color variable names and values, even though they are empty
stacyk Aug 1, 2022
05ae64e
Merge branch 'main' into sass-config
jgerigmeyer Aug 1, 2022
fc17e22
lint
jgerigmeyer Aug 1, 2022
b0faf7a
Merge branch 'main' into sass-config
jgerigmeyer Aug 1, 2022
065a1d5
Merge branch 'main' into sass-config
jgerigmeyer Aug 9, 2022
1f69e67
update linter
jgerigmeyer Aug 9, 2022
4ea9c73
fix font
jgerigmeyer Aug 9, 2022
035adff
compiled webmention timestamp?
stacyk Aug 9, 2022
e80092a
add another @group init-colors to control order of heading and example
stacyk Aug 9, 2022
6038318
linted on save
stacyk Aug 9, 2022
8727442
lint
jgerigmeyer Aug 9, 2022
2ab4196
Show content-color names/values in herman example
mirisuzanne Aug 10, 2022
5d9427a
allow herman to show color values for now instead of previews
stacyk Aug 11, 2022
228667a
adjust headings
jgerigmeyer Aug 11, 2022
a759111
update sass comment sicne we arent compressing our css output
stacyk Aug 11, 2022
0309188
Merge branch 'sass-config' of https://github.com/oddbird/oddleventy i…
stacyk Aug 11, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 0 additions & 9 deletions src/scss/config/color/_content.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,12 +1,3 @@
/// ## Content Colors
/// --------------
/// Rather than using the brand colors directly,
/// we use them to set default values for generated variables.
/// This provides a mapping between semantic foreground use-cases,
/// and automatically-generated color variables.
/// @colors content-colors
/// @group config-color

$text: var(--ccs-neutral--fg-full);
$text-light: var(--ccs-neutral--fg3);
$accent: var(--ccs-accent--fg1);
Expand Down
15 changes: 15 additions & 0 deletions src/scss/config/color/_index.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,21 @@
tools.compile-colors(meta.module-variables('ccs-defaults'))
);

/// ## Content Colors
/// --------------
/// Rather than using the brand colors directly,
/// we use them to set default values for generated variables.
/// This provides a mapping between semantic foreground use-cases,
/// and automatically-generated color variables.
/// @group config-color
/// @example scss
/// @use 'config/color/content';
/// @use 'config/tools';
/// @use 'sass:meta';
///
/// @each $name, $color in tools.compile-colors(meta.module-variables('content')) {
/// /*! #{$name}: #{$color}; */
/// }
@include herman.add(
'colors',
'content-colors',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mirisuzanne doesn't this content-colors here reference the /// @colors content-colors line that we no longer have from the src/scss/config/color/_content.scss file?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

uh, yes, I guess so - that line is adding the colors to Herman, even though (for now) we're not displaying them with Herman. So it's not doing anything useful, but also not causing any issues. We could remove that herman.add for now, or just leave it so it works once we add custom property support to Herman? Either way.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, I'd say we can leave it there for now since it doesn't hurt anything and maybe if/when we update Herman we will be in good shape.

Expand Down